kernel: add fix for bgmac with B50212E B1 PHY
This PHY requires some extra programming to work reliably with all devices. Backport upstream fix for it. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
This commit is contained in:
parent
878456caf6
commit
2cd32a3304
8 changed files with 204 additions and 6 deletions
|
@ -0,0 +1,50 @@
|
||||||
|
From 12acd136913ccdf394eeb2bc8686ff5505368119 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
|
Date: Thu, 12 Oct 2017 10:21:26 +0200
|
||||||
|
Subject: [PATCH] net: bgmac: enable master mode for BCM54210E and B50212E PHYs
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
There are 4 very similar PHYs:
|
||||||
|
0x600d84a1: BCM54210E (rev B0)
|
||||||
|
0x600d84a2: BCM54210E (rev B1)
|
||||||
|
0x600d84a5: B50212E (rev B0)
|
||||||
|
0x600d84a6: B50212E (rev B1)
|
||||||
|
that need setting master mode manually. It's because they run in slave
|
||||||
|
mode by default with Automatic Slave/Master configuration disabled which
|
||||||
|
can lead to unreliable connection with massive ping loss.
|
||||||
|
|
||||||
|
So far it was reported for a board with BCM47189 SoC and B50212E B1 PHY
|
||||||
|
connected to the bgmac supported ethernet device. Telling PHY driver to
|
||||||
|
setup PHY properly solves this issue.
|
||||||
|
|
||||||
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||||
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||||||
|
---
|
||||||
|
drivers/net/ethernet/broadcom/bgmac-bcma.c | 8 +++++++-
|
||||||
|
1 file changed, 7 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
|
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
|
@@ -159,13 +159,19 @@ static int bgmac_probe(struct bcma_devic
|
||||||
|
|
||||||
|
if (!bgmac_is_bcm4707_family(core) &&
|
||||||
|
!(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) {
|
||||||
|
+ struct phy_device *phydev;
|
||||||
|
+
|
||||||
|
mii_bus = bcma_mdio_mii_register(bgmac);
|
||||||
|
if (IS_ERR(mii_bus)) {
|
||||||
|
err = PTR_ERR(mii_bus);
|
||||||
|
goto err;
|
||||||
|
}
|
||||||
|
-
|
||||||
|
bgmac->mii_bus = mii_bus;
|
||||||
|
+
|
||||||
|
+ phydev = mdiobus_get_phy(bgmac->mii_bus, bgmac->phyaddr);
|
||||||
|
+ if (ci->id == BCMA_CHIP_ID_BCM53573 && phydev &&
|
||||||
|
+ (phydev->drv->phy_id & phydev->drv->phy_id_mask) == PHY_ID_BCM54210E)
|
||||||
|
+ phydev->dev_flags |= PHY_BRCM_EN_MASTER_MODE;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) {
|
|
@ -0,0 +1,54 @@
|
||||||
|
From 2355a6546a053b1c16ebefd6ce1f0cccc00e1da5 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
|
Date: Thu, 12 Oct 2017 10:21:25 +0200
|
||||||
|
Subject: [PATCH] net: phy: broadcom: support new device flag for setting
|
||||||
|
master mode
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Some of Broadcom's PHYs run by default in slave mode with Automatic
|
||||||
|
Slave/Master configuration disabled. It stops them from working properly
|
||||||
|
with some devices.
|
||||||
|
|
||||||
|
So far it has been verified for BCM54210E and BCM50212E which don't
|
||||||
|
work well with Intel's I217-LM and I218-LM:
|
||||||
|
http://ark.intel.com/products/60019/Intel-Ethernet-Connection-I217-LM
|
||||||
|
http://ark.intel.com/products/71307/Intel-Ethernet-Connection-I218-LM
|
||||||
|
I was told there is massive ping loss.
|
||||||
|
|
||||||
|
This commit adds support for a new flag which can be set by an ethernet
|
||||||
|
driver to fixup PHY setup.
|
||||||
|
|
||||||
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||||
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||||||
|
---
|
||||||
|
drivers/net/phy/broadcom.c | 6 ++++++
|
||||||
|
include/linux/brcmphy.h | 1 +
|
||||||
|
2 files changed, 7 insertions(+)
|
||||||
|
|
||||||
|
--- a/drivers/net/phy/broadcom.c
|
||||||
|
+++ b/drivers/net/phy/broadcom.c
|
||||||
|
@@ -43,6 +43,12 @@ static int bcm54210e_config_init(struct
|
||||||
|
val &= ~BCM54810_SHD_CLK_CTL_GTXCLK_EN;
|
||||||
|
bcm_phy_write_shadow(phydev, BCM54810_SHD_CLK_CTL, val);
|
||||||
|
|
||||||
|
+ if (phydev->dev_flags & PHY_BRCM_EN_MASTER_MODE) {
|
||||||
|
+ val = phy_read(phydev, MII_CTRL1000);
|
||||||
|
+ val |= CTL1000_AS_MASTER | CTL1000_ENABLE_MASTER;
|
||||||
|
+ phy_write(phydev, MII_CTRL1000, val);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
--- a/include/linux/brcmphy.h
|
||||||
|
+++ b/include/linux/brcmphy.h
|
||||||
|
@@ -59,6 +59,7 @@
|
||||||
|
#define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000
|
||||||
|
#define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000
|
||||||
|
#define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000
|
||||||
|
+#define PHY_BRCM_EN_MASTER_MODE 0x00010000
|
||||||
|
|
||||||
|
/* Broadcom BCM7xxx specific workarounds */
|
||||||
|
#define PHY_BRCM_7XXX_REV(x) (((x) >> 8) & 0xff)
|
|
@ -14,7 +14,7 @@ Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
|
||||||
|
|
||||||
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
@@ -230,6 +230,7 @@ static int bgmac_probe(struct bcma_devic
|
@@ -236,6 +236,7 @@ static int bgmac_probe(struct bcma_devic
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
|
bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_NO_RESET;
|
bgmac->feature_flags |= BGMAC_FEAT_NO_RESET;
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_FORCE_SPEED_2500;
|
bgmac->feature_flags |= BGMAC_FEAT_FORCE_SPEED_2500;
|
||||||
|
|
|
@ -0,0 +1,50 @@
|
||||||
|
From 12acd136913ccdf394eeb2bc8686ff5505368119 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
|
Date: Thu, 12 Oct 2017 10:21:26 +0200
|
||||||
|
Subject: [PATCH] net: bgmac: enable master mode for BCM54210E and B50212E PHYs
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
There are 4 very similar PHYs:
|
||||||
|
0x600d84a1: BCM54210E (rev B0)
|
||||||
|
0x600d84a2: BCM54210E (rev B1)
|
||||||
|
0x600d84a5: B50212E (rev B0)
|
||||||
|
0x600d84a6: B50212E (rev B1)
|
||||||
|
that need setting master mode manually. It's because they run in slave
|
||||||
|
mode by default with Automatic Slave/Master configuration disabled which
|
||||||
|
can lead to unreliable connection with massive ping loss.
|
||||||
|
|
||||||
|
So far it was reported for a board with BCM47189 SoC and B50212E B1 PHY
|
||||||
|
connected to the bgmac supported ethernet device. Telling PHY driver to
|
||||||
|
setup PHY properly solves this issue.
|
||||||
|
|
||||||
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||||
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||||||
|
---
|
||||||
|
drivers/net/ethernet/broadcom/bgmac-bcma.c | 8 +++++++-
|
||||||
|
1 file changed, 7 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
|
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
|
@@ -159,13 +159,19 @@ static int bgmac_probe(struct bcma_devic
|
||||||
|
|
||||||
|
if (!bgmac_is_bcm4707_family(core) &&
|
||||||
|
!(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) {
|
||||||
|
+ struct phy_device *phydev;
|
||||||
|
+
|
||||||
|
mii_bus = bcma_mdio_mii_register(bgmac);
|
||||||
|
if (IS_ERR(mii_bus)) {
|
||||||
|
err = PTR_ERR(mii_bus);
|
||||||
|
goto err;
|
||||||
|
}
|
||||||
|
-
|
||||||
|
bgmac->mii_bus = mii_bus;
|
||||||
|
+
|
||||||
|
+ phydev = bgmac->mii_bus->phy_map[bgmac->phyaddr];
|
||||||
|
+ if (ci->id == BCMA_CHIP_ID_BCM53573 && phydev &&
|
||||||
|
+ (phydev->drv->phy_id & phydev->drv->phy_id_mask) == PHY_ID_BCM54210E)
|
||||||
|
+ phydev->dev_flags |= PHY_BRCM_EN_MASTER_MODE;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) {
|
|
@ -1,6 +1,5 @@
|
||||||
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
Subject: [PATCH 1/2] net: phy: cherry-pick Broadcom drivers updates from
|
Subject: [PATCH] net: phy: cherry-pick Broadcom drivers updates from v4.10
|
||||||
v4.10-rc1
|
|
||||||
MIME-Version: 1.0
|
MIME-Version: 1.0
|
||||||
Content-Type: text/plain; charset=UTF-8
|
Content-Type: text/plain; charset=UTF-8
|
||||||
Content-Transfer-Encoding: 8bit
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
|
@ -1,10 +1,18 @@
|
||||||
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
Subject: [PATCH 2/2] net: phy: pick Broadcom drivers updates from net-next for
|
Subject: [PATCH] net: phy: cherry-pick Broadcom drivers updates from v4.11
|
||||||
4.11
|
|
||||||
MIME-Version: 1.0
|
MIME-Version: 1.0
|
||||||
Content-Type: text/plain; charset=UTF-8
|
Content-Type: text/plain; charset=UTF-8
|
||||||
Content-Transfer-Encoding: 8bit
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
This includes following upstream commits:
|
||||||
|
62e13097c46c net: phy: broadcom: rehook BCM54612E specific init
|
||||||
|
0fc9ae107669 net: phy: broadcom: add support for BCM54210E
|
||||||
|
5e7bfa6cb0a9 net: phy: bcm-phy-lib: clean up remaining AUXCTL register defines
|
||||||
|
8293c7bcdef1 net: phy: broadcom: drop duplicated define for RGMII SKEW delay
|
||||||
|
85b4685da52f net: phy: broadcom: use auxctl reading helper in BCM54612E code
|
||||||
|
039a7b8592ab net: phy: bcm7xxx: Implement EGPHY workaround for 7278
|
||||||
|
582d0ac397ca net: phy: bcm7xxx: Add entry for BCM7278
|
||||||
|
|
||||||
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||||
---
|
---
|
||||||
|
|
|
@ -0,0 +1,37 @@
|
||||||
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||||
|
Subject: [PATCH] net: phy: cherry-pick Broadcom drivers updates from v4.15
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
This includes following upstream commits:
|
||||||
|
2355a6546a05 net: phy: broadcom: support new device flag for setting master mode
|
||||||
|
|
||||||
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||||
|
---
|
||||||
|
|
||||||
|
--- a/drivers/net/phy/broadcom.c
|
||||||
|
+++ b/drivers/net/phy/broadcom.c
|
||||||
|
@@ -43,6 +43,12 @@ static int bcm54210e_config_init(struct
|
||||||
|
val &= ~BCM54810_SHD_CLK_CTL_GTXCLK_EN;
|
||||||
|
bcm_phy_write_shadow(phydev, BCM54810_SHD_CLK_CTL, val);
|
||||||
|
|
||||||
|
+ if (phydev->dev_flags & PHY_BRCM_EN_MASTER_MODE) {
|
||||||
|
+ val = phy_read(phydev, MII_CTRL1000);
|
||||||
|
+ val |= CTL1000_AS_MASTER | CTL1000_ENABLE_MASTER;
|
||||||
|
+ phy_write(phydev, MII_CTRL1000, val);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
--- a/include/linux/brcmphy.h
|
||||||
|
+++ b/include/linux/brcmphy.h
|
||||||
|
@@ -59,6 +59,7 @@
|
||||||
|
#define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000
|
||||||
|
#define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000
|
||||||
|
#define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000
|
||||||
|
+#define PHY_BRCM_EN_MASTER_MODE 0x00010000
|
||||||
|
|
||||||
|
/* Broadcom BCM7xxx specific workarounds */
|
||||||
|
#define PHY_BRCM_7XXX_REV(x) (((x) >> 8) & 0xff)
|
|
@ -78,7 +78,7 @@ Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
|
||||||
struct bgmac *bgmac_alloc(struct device *dev);
|
struct bgmac *bgmac_alloc(struct device *dev);
|
||||||
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
|
||||||
@@ -230,6 +230,7 @@ static int bgmac_probe(struct bcma_devic
|
@@ -236,6 +236,7 @@ static int bgmac_probe(struct bcma_devic
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
|
bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_NO_RESET;
|
bgmac->feature_flags |= BGMAC_FEAT_NO_RESET;
|
||||||
bgmac->feature_flags |= BGMAC_FEAT_FORCE_SPEED_2500;
|
bgmac->feature_flags |= BGMAC_FEAT_FORCE_SPEED_2500;
|
||||||
|
|
Loading…
Reference in a new issue