2016-08-16 15:40:32 +00:00
|
|
|
From 3894396e64994f31c3ef5c7e6f63dded0593e567 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Florian Fainelli <f.fainelli@gmail.com>
|
|
|
|
|
Date: Thu, 23 Jun 2016 14:25:33 -0700
|
|
|
|
|
Subject: [PATCH 3/3] net: bgmac: Remove superflous netif_carrier_on()
|
|
|
|
|
|
|
|
|
|
bgmac_open() calls phy_start() to initialize the PHY state machine,
|
|
|
|
|
which will set the interface's carrier state accordingly, no need to
|
|
|
|
|
force that as this could be conflicting with the PHY state determined by
|
|
|
|
|
PHYLIB.
|
|
|
|
|
|
|
|
|
|
Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
|
|
|
|
|
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
|
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/ethernet/broadcom/bgmac.c | 2 --
|
|
|
|
|
1 file changed, 2 deletions(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/ethernet/broadcom/bgmac.c
|
|
|
|
|
+++ b/drivers/net/ethernet/broadcom/bgmac.c
|
2016-11-21 18:18:47 +00:00
|
|
|
@@ -1326,8 +1326,6 @@ static int bgmac_open(struct net_device
|
2016-08-16 15:40:32 +00:00
|
|
|
|
|
|
|
|
phy_start(net_dev->phydev);
|
|
|
|
|
|
|
|
|
|
- netif_carrier_on(net_dev);
|
|
|
|
|
-
|
|
|
|
|
netif_start_queue(net_dev);
|
|
|
|
|
|
|
|
|
|
return 0;
|
