2016-04-29 11:34:31 +00:00
|
|
|
From 8b6bb80616460eda2e70e358c5fb70c0f4d4d02f Mon Sep 17 00:00:00 2001
|
2016-03-22 21:14:51 +00:00
|
|
|
From: Arnd Bergmann <arnd@arndb.de>
|
|
|
|
|
Date: Mon, 14 Mar 2016 15:07:11 +0100
|
2016-04-29 11:34:31 +00:00
|
|
|
Subject: [PATCH 68/91] net: mediatek: remove incorrect dma_mask assignment
|
2016-03-22 21:14:51 +00:00
|
|
|
|
|
|
|
|
Device drivers should not mess with the DMA mask directly,
|
|
|
|
|
but instead call dma_set_mask() etc if needed.
|
|
|
|
|
|
|
|
|
|
In case of the mtk_eth_soc driver, the mask already gets set
|
|
|
|
|
correctly when the device is created, and setting it again
|
|
|
|
|
is against the documented API.
|
|
|
|
|
|
|
|
|
|
This removes the incorrect setting.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 ---
|
|
|
|
|
1 file changed, 3 deletions(-)
|
|
|
|
|
|
2016-04-26 11:43:38 +00:00
|
|
|
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
index a005bc4..fcd4ed7 100644
|
2016-03-22 21:14:51 +00:00
|
|
|
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
2016-04-26 11:43:38 +00:00
|
|
|
@@ -1678,9 +1678,6 @@ static int mtk_probe(struct platform_device *pdev)
|
2016-03-22 21:14:51 +00:00
|
|
|
struct mtk_eth *eth;
|
|
|
|
|
int err;
|
|
|
|
|
|
|
|
|
|
- pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
|
|
|
|
|
- pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
|
|
|
|
|
-
|
|
|
|
|
device_reset(&pdev->dev);
|
|
|
|
|
|
|
|
|
|
match = of_match_device(of_mtk_match, &pdev->dev);
|
2016-04-26 11:43:38 +00:00
|
|
|
--
|
|
|
|
|
1.7.10.4
|
|
|
|
|
|
