33 lines
1.3 KiB
Diff
33 lines
1.3 KiB
Diff
|
From 3e9e15ec9e56874764fdaa43b2af8008469b87b2 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= <noralf@tronnes.org>
|
||
|
|
Date: Mon, 19 Sep 2016 17:19:41 +0200
|
||
|
|
Subject: [PATCH] i2c: bcm2835: Use dev_dbg logging on transfer errors
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
Writing to an AT24C32 generates on average 2x i2c transfer errors per
|
||
|
|
32-byte page write. Which amounts to a lot for a 4k write. This is due
|
||
|
|
to the fact that the chip doesn't respond during it's internal write
|
||
|
|
cycle when the at24 driver tries and retries the next write.
|
||
|
|
Only a handful drivers use dev_err() on transfer error, so switch to
|
||
|
|
dev_dbg() instead.
|
||
|
|
|
||
|
|
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
|
||
|
|
Reviewed-by: Eric Anholt <eric@anholt.net>
|
||
|
|
---
|
||
|
|
drivers/i2c/busses/i2c-bcm2835.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/i2c/busses/i2c-bcm2835.c
|
||
|
|
+++ b/drivers/i2c/busses/i2c-bcm2835.c
|
||
|
|
@@ -216,7 +216,7 @@ static int bcm2835_i2c_xfer_msg(struct b
|
||
|
|
(msg->flags & I2C_M_IGNORE_NAK))
|
||
|
|
return 0;
|
||
|
|
|
||
|
|
- dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
|
||
|
|
+ dev_dbg(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
|
||
|
|
|
||
|
|
if (i2c_dev->msg_err & BCM2835_I2C_S_ERR)
|
||
|
|
return -EREMOTEIO;
|