From ebfc1c029d13171dcd97b469ba29b34e01ea7d6e Mon Sep 17 00:00:00 2001
From: Brendan Heywood <brendan@catalyst-au.net>
Date: Wed, 4 Nov 2020 14:25:36 +1100
Subject: [PATCH] PDFs should be inline not attachments #153

---
 classes/template.php | 2 +-
 view.php             | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/classes/template.php b/classes/template.php
index fd2f0de..6bf8ac0 100644
--- a/classes/template.php
+++ b/classes/template.php
@@ -320,7 +320,7 @@ class template {
                 return $pdf->Output('', 'S');
             }
 
-            $pdf->Output($filename, 'D');
+            $pdf->Output($filename, 'I');
         }
     }
 
diff --git a/view.php b/view.php
index 93b5b45..2486b5f 100644
--- a/view.php
+++ b/view.php
@@ -139,7 +139,7 @@ if (!$downloadown && !$downloadissue) {
     if ($canreceive) {
         $linkname = get_string('getcustomcert', 'customcert');
         $link = new moodle_url('/mod/customcert/view.php', array('id' => $cm->id, 'downloadown' => true));
-        $downloadbutton = new single_button($link, $linkname, 'post', true);
+        $downloadbutton = new single_button($link, $linkname, 'get', true);
         $downloadbutton->class .= ' m-b-1';  // Seems a bit hackish, ahem.
         $downloadbutton = $OUTPUT->render($downloadbutton);
     }
@@ -179,6 +179,8 @@ if (!$downloadown && !$downloadissue) {
         redirect(new moodle_url('/mod/customcert/view.php', array('id' => $cm->id)));
     }
 
+    \core\session\manager::write_close();
+
     // Now we want to generate the PDF.
     $template = new \mod_customcert\template($template);
     $template->generate_pdf(false, $userid);