KumiSystems/moodle-mod_htmlcert
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix Moodle Code Checker complaints

Browse source
This commit is contained in:
Mark Nelson 2021-05-27 18:24:01 +08:00
parent 9f320984c6
commit 69a3436faa
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
backup/moodle2/backup_customcert_activity_task.class.php
View file

@ -56,7 +56,7 @@ class backup_customcert_activity_task extends backup_activity_task {
* @param string $content * @param string $content
* @return mixed|string * @return mixed|string
*/ */
static public function encode_content_links($content) { public static function encode_content_links($content) {
global $CFG; global $CFG;
$base = preg_quote($CFG->wwwroot, "/"); $base = preg_quote($CFG->wwwroot, "/");

6
backup/moodle2/restore_customcert_activity_task.class.php
View file

@ -53,7 +53,7 @@ class restore_customcert_activity_task extends restore_activity_task {
/** /**
* Define the contents in the activity that must be processed by the link decoder. * Define the contents in the activity that must be processed by the link decoder.
*/ */
static public function define_decode_contents() { public static function define_decode_contents() {
$contents = array(); $contents = array();
$contents[] = new restore_decode_content('customcert', array('intro'), 'customcert'); $contents[] = new restore_decode_content('customcert', array('intro'), 'customcert');
@ -64,7 +64,7 @@ class restore_customcert_activity_task extends restore_activity_task {
/** /**
* Define the decoding rules for links belonging to the activity to be executed by the link decoder. * Define the decoding rules for links belonging to the activity to be executed by the link decoder.
*/ */
static public function define_decode_rules() { public static function define_decode_rules() {
$rules = array(); $rules = array();
$rules[] = new restore_decode_rule('CUSTOMCERTVIEWBYID', '/mod/customcert/view.php?id=$1', 'course_module'); $rules[] = new restore_decode_rule('CUSTOMCERTVIEWBYID', '/mod/customcert/view.php?id=$1', 'course_module');
@ -80,7 +80,7 @@ class restore_customcert_activity_task extends restore_activity_task {
* *
* @return array the restore log rules * @return array the restore log rules
*/ */
static public function define_restore_log_rules() { public static function define_restore_log_rules() {
$rules = array(); $rules = array();
$rules[] = new restore_log_rule('customcert', 'add', 'view.php?id={course_module}', '{customcert}'); $rules[] = new restore_log_rule('customcert', 'add', 'view.php?id={course_module}', '{customcert}');

4
classes/element.php
View file

@ -377,7 +377,7 @@ abstract class element {
* @param bool $preview true if it is a preview, false otherwise * @param bool $preview true if it is a preview, false otherwise
* @param \stdClass $user the user we are rendering this for * @param \stdClass $user the user we are rendering this for
*/ */
public abstract function render($pdf, $preview, $user); abstract public function render($pdf, $preview, $user);
/** /**
* Render the element in html. * Render the element in html.
@ -389,7 +389,7 @@ abstract class element {
* *
* @return string the html * @return string the html
*/ */
public abstract function render_html(); abstract public function render_html();
/** /**
* Handles deleting any data this element may have introduced. * Handles deleting any data this element may have introduced.

2
my_certificates.php
View file

@ -49,7 +49,7 @@ $user = \core_user::get_user($userid, '*', MUST_EXIST);
// If we are viewing certificates that are not for the currently logged in user then do a capability check. // If we are viewing certificates that are not for the currently logged in user then do a capability check.
if (($userid != $USER->id) && !has_capability('mod/customcert:viewallcertificates', context_system::instance())) { if (($userid != $USER->id) && !has_capability('mod/customcert:viewallcertificates', context_system::instance())) {
print_error('You are not allowed to view these certificates'); throw new moodle_exception('You are not allowed to view these certificates');
} }
$PAGE->set_url($pageurl); $PAGE->set_url($pageurl);