KumiSystems/moodle-mod_htmlcert
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

#16 Fixed minor issues with web services

Browse source
This commit is contained in:
Mark Nelson 2016-08-22 14:18:07 +08:00
parent 38103385b4
commit 5f09a9aca0
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
classes/external.php
View file

@ -67,6 +67,13 @@ class external extends \external_api {
public static function save_element($templateid, $elementid, $values) { public static function save_element($templateid, $elementid, $values) {
global $DB; global $DB;
$params = array(
'templateid' => $templateid,
'elementid' => $elementid,
'values' => $values
);
self::validate_parameters(self::save_element_parameters(), $params);
$template = $DB->get_record('customcert_templates', array('id' => $templateid), '*', MUST_EXIST); $template = $DB->get_record('customcert_templates', array('id' => $templateid), '*', MUST_EXIST);
$element = $DB->get_record('customcert_elements', array('id' => $elementid), '*', MUST_EXIST); $element = $DB->get_record('customcert_elements', array('id' => $elementid), '*', MUST_EXIST);
@ -75,9 +82,9 @@ class external extends \external_api {
// Perform checks. // Perform checks.
if ($cm = $template->get_cm()) { if ($cm = $template->get_cm()) {
require_login($cm->course, false, $cm); self::validate_context(\context_module::instance($cm->id));
} else { } else {
require_login(); self::validate_context(\context_system::instance());
} }
// Make sure the user has the required capabilities. // Make sure the user has the required capabilities.
$template->require_manage(); $template->require_manage();
@ -132,6 +139,12 @@ class external extends \external_api {
public static function get_element_html($templateid, $elementid) { public static function get_element_html($templateid, $elementid) {
global $DB; global $DB;
$params = array(
'templateid' => $templateid,
'elementid' => $elementid
);
self::validate_parameters(self::get_element_html_parameters(), $params);
$template = $DB->get_record('customcert_templates', array('id' => $templateid), '*', MUST_EXIST); $template = $DB->get_record('customcert_templates', array('id' => $templateid), '*', MUST_EXIST);
$element = $DB->get_record('customcert_elements', array('id' => $elementid), '*', MUST_EXIST); $element = $DB->get_record('customcert_elements', array('id' => $elementid), '*', MUST_EXIST);
@ -140,9 +153,9 @@ class external extends \external_api {
// Perform checks. // Perform checks.
if ($cm = $template->get_cm()) { if ($cm = $template->get_cm()) {
require_login($cm->course, false, $cm); self::validate_context(\context_module::instance($cm->id));
} else { } else {
require_login(); self::validate_context(\context_system::instance());
} }
// Get an instance of the element class. // Get an instance of the element class.