From 38def6bfb405b96fcc80a408c9c183418ba91055 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Tue, 28 May 2019 23:56:02 +0800 Subject: [PATCH] Fix complaints found by local_moodlecheck --- element/daterange/classes/element.php | 3 +++ element/daterange/tests/element_test.php | 7 +++++++ .../daterange/tests/fixtures/fake_datarange_element.php | 7 +++++++ element/qrcode/classes/element.php | 4 +++- 4 files changed, 20 insertions(+), 1 deletion(-) diff --git a/element/daterange/classes/element.php b/element/daterange/classes/element.php index e6c56cd..141d98f 100644 --- a/element/daterange/classes/element.php +++ b/element/daterange/classes/element.php @@ -442,6 +442,8 @@ class element extends \mod_customcert\element { } /** + * Returns whether or not a range is recurring. + * * @param \stdClass $range Range object. * * @return bool @@ -597,6 +599,7 @@ class element extends \mod_customcert\element { /** * Format date string based on different types of placeholders. * + * @param string $datestring The date string * @param array $formatdata A list of format data. * * @return string diff --git a/element/daterange/tests/element_test.php b/element/daterange/tests/element_test.php index 7ac47af..eb58cdd 100644 --- a/element/daterange/tests/element_test.php +++ b/element/daterange/tests/element_test.php @@ -27,6 +27,13 @@ global $CFG; require_once($CFG->dirroot . '/mod/customcert/element/daterange/tests/fixtures/fake_datarange_element.php'); +/** + * Test datarange element. + * + * @package customcertelement_daterange + * @copyright 2018 Dmitrii Metelkin + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ class customcertelement_daterange_element_test extends advanced_testcase { /** diff --git a/element/daterange/tests/fixtures/fake_datarange_element.php b/element/daterange/tests/fixtures/fake_datarange_element.php index ff6a18c..e39b3a2 100644 --- a/element/daterange/tests/fixtures/fake_datarange_element.php +++ b/element/daterange/tests/fixtures/fake_datarange_element.php @@ -24,6 +24,13 @@ defined('MOODLE_INTERNAL') || die(); +/** + * Fake datarange element for testing. + * + * @package customcertelement_daterange + * @copyright 2018 Dmitrii Metelkin + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ class fake_datarange_element extends \customcertelement_daterange\element { /** diff --git a/element/qrcode/classes/element.php b/element/qrcode/classes/element.php index 3f1329b..0851221 100644 --- a/element/qrcode/classes/element.php +++ b/element/qrcode/classes/element.php @@ -37,7 +37,9 @@ require_once($CFG->libdir . '/tcpdf/tcpdf_barcodes_2d.php'); */ class element extends \mod_customcert\element { - + /** + * @var string The barcode type. + */ const BARCODETYPE = 'QRCODE'; /**