KumiSystems/moodle-mod_htmlcert
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Removed unused variables and altered comments

Browse source
This commit is contained in:
Mark Nelson 2013-05-30 17:53:19 +08:00
parent 0dc1ef19c9
commit 35851b204c
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
lib.php
View file

@ -180,7 +180,7 @@ function customcert_delete_instance($id) {
* @return array status array * @return array status array
*/ */
function customcert_reset_userdata($data) { function customcert_reset_userdata($data) {
global $CFG, $DB; global $DB;
$componentstr = get_string('modulenameplural', 'customcert'); $componentstr = get_string('modulenameplural', 'customcert');
$status = array(); $status = array();
@ -331,7 +331,7 @@ function customcert_cron () {
* @param navigation_node $customcertnode * @param navigation_node $customcertnode
*/ */
function customcert_extend_settings_navigation(settings_navigation $settings, navigation_node $customcertnode) { function customcert_extend_settings_navigation(settings_navigation $settings, navigation_node $customcertnode) {
global $PAGE, $CFG; global $PAGE;
$keys = $customcertnode->get_children_key_list(); $keys = $customcertnode->get_children_key_list();
$beforekey = null; $beforekey = null;
@ -359,9 +359,6 @@ function customcert_extend_settings_navigation(settings_navigation $settings, na
* @param int $draftitemid the draft area containing the files * @param int $draftitemid the draft area containing the files
*/ */
function customcert_upload_imagefiles($draftitemid) { function customcert_upload_imagefiles($draftitemid) {
// Get the filestorage object.
$fs = get_file_storage();
// Save the file if it exists that is currently in the draft area. // Save the file if it exists that is currently in the draft area.
file_save_draft_area_files($draftitemid, context_system::instance()->id, 'mod_customcert', 'image', 0); file_save_draft_area_files($draftitemid, context_system::instance()->id, 'mod_customcert', 'image', 0);
} }
@ -477,7 +474,7 @@ function customcert_get_font_sizes() {
* @param stdClass $data the customcert data * @param stdClass $data the customcert data
*/ */
function customcert_save_page_data($data) { function customcert_save_page_data($data) {
global $CFG, $DB; global $DB;
// Set the time to a variable. // Set the time to a variable.
$time = time(); $time = time();
@ -541,8 +538,6 @@ function customcert_get_element_instance($element) {
* @param int $pageid the page id we are saving it to * @param int $pageid the page id we are saving it to
*/ */
function customcert_add_element($element, $pageid) { function customcert_add_element($element, $pageid) {
global $CFG;
$classname = "customcert_element_{$element}"; $classname = "customcert_element_{$element}";
$classname::add_element($element, $pageid); $classname::add_element($element, $pageid);
} }
@ -597,7 +592,7 @@ function customcert_add_page($data) {
* @param int $pageid the customcert page * @param int $pageid the customcert page
*/ */
function customcert_delete_page($pageid) { function customcert_delete_page($pageid) {
global $CFG, $DB; global $DB;
// Get the page. // Get the page.
$page = $DB->get_record('customcert_pages', array('id' => $pageid), '*', MUST_EXIST); $page = $DB->get_record('customcert_pages', array('id' => $pageid), '*', MUST_EXIST);
@ -687,13 +682,15 @@ function customcert_get_course_time($courseid) {
* @return stdClass the users * @return stdClass the users
*/ */
function customcert_get_issues($customcertid, $groupmode, $cm, $page, $perpage) { function customcert_get_issues($customcertid, $groupmode, $cm, $page, $perpage) {
global $CFG, $DB; global $DB;
// Get the conditional SQL.
list($conditionssql, $conditionsparams) = customcert_get_conditional_issues_sql($cm, $groupmode); list($conditionssql, $conditionsparams) = customcert_get_conditional_issues_sql($cm, $groupmode);
// Get all the users that have customcerts issued, should only be one issue per user for a customcert // Add the conditional SQL and the customcertid to form all used parameters.
$allparams = $conditionsparams + array('customcertid' => $customcertid); $allparams = $conditionsparams + array('customcertid' => $customcertid);
// Return the issues.
return $DB->get_records_sql("SELECT u.*, ci.code, ci.timecreated return $DB->get_records_sql("SELECT u.*, ci.code, ci.timecreated
FROM {user} u FROM {user} u
INNER JOIN {customcert_issues} ci INNER JOIN {customcert_issues} ci
@ -718,11 +715,13 @@ function customcert_get_issues($customcertid, $groupmode, $cm, $page, $perpage)
function customcert_get_number_of_issues($customcertid, $cm, $groupmode) { function customcert_get_number_of_issues($customcertid, $cm, $groupmode) {
global $DB; global $DB;
// Get the conditional SQL.
list($conditionssql, $conditionsparams) = customcert_get_conditional_issues_sql($cm, $groupmode); list($conditionssql, $conditionsparams) = customcert_get_conditional_issues_sql($cm, $groupmode);
// Get all the users that have customcerts issued, should only be one issue per user for a customcert. // Add the conditional SQL and the customcertid to form all used parameters.
$allparams = $conditionsparams + array('customcertid' => $customcertid); $allparams = $conditionsparams + array('customcertid' => $customcertid);
// Return the number of issues.
return $DB->count_records_sql("SELECT COUNT(u.*) as count return $DB->count_records_sql("SELECT COUNT(u.*) as count
FROM {user} u FROM {user} u
INNER JOIN {customcert_issues} ci INNER JOIN {customcert_issues} ci