KumiSystems/moodle-mod_htmlcert
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixed issue when scales are used (#242)

Browse source 
The grade item's type was being hard-coded to
GRADE_TYPE_VALUE when this isn't always the
case.
This commit is contained in:
Mark Nelson 2018-12-19 12:08:27 +08:00
parent 94c32de40f
commit 1b4de1c53a
1 changed files with 26 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
classes/element_helper.php
View file

@ -542,31 +542,44 @@ class element_helper {
return false; return false;
} }
$gradeitem = grade_get_grades($cm->course, 'mod', $module->name, $cm->instance, $userid); $params = [
'itemtype' => 'mod',
'itemmodule' => $module->name,
'iteminstance' => $cm->instance,
'courseid' => $cm->course,
'itemnumber' => 0
];
$gradeitem = \grade_item::fetch($params);
if (empty($gradeitem)) { if (empty($gradeitem)) {
return false; return false;
} }
$item = new \grade_item(); $grade = grade_get_grades(
$item->gradetype = GRADE_TYPE_VALUE; $cm->course,
$item->courseid = $cm->course; 'mod',
$itemproperties = reset($gradeitem->items); $module->name,
foreach ($itemproperties as $key => $value) { $cm->instance,
$item->$key = $value; $userid
);
if (!isset($grade->items[0]->grades[$userid])) {
return false;
} }
$objgrade = $item->grades[$userid]; $gradebookgrade = $grade->items[0]->grades[$userid];
$dategraded = null; $dategraded = null;
if (!empty($objgrade->dategraded)) { if (!empty($gradebookgrade->dategraded)) {
$dategraded = $objgrade->dategraded; $dategraded = $gradebookgrade->dategraded;
} }
$displaygrade = grade_format_gradevalue($gradebookgrade->grade, $gradeitem, true, $gradeformat);
return new grade_information( return new grade_information(
$item->name, $gradeitem->get_name(),
$objgrade->grade, $gradebookgrade->grade,
grade_format_gradevalue($objgrade->grade, $item, true, $gradeformat), $displaygrade,
$dategraded $dategraded
); );
} }