Move creating the temp directory out of the emailing for loop (#238)

This commit is contained in:
mwithheld 2018-12-17 15:23:28 +08:00 committed by Mark Nelson
parent f1d6813889
commit 06a7595c85

View file

@ -154,16 +154,16 @@ class email_certificate_task extends \core\task\scheduled_task {
continue;
}
// Create a directory to store the PDF we will be sending.
$tempdir = make_temp_directory('certificate/attachment');
if (!$tempdir) {
return;
}
// Now, email the people we need to.
foreach ($issuedusers as $user) {
$userfullname = fullname($user);
// Create a directory to store the PDF we will be sending.
$tempdir = make_temp_directory('certificate/attachment');
if (!$tempdir) {
return false;
}
// Now, get the PDF.
$template = new \stdClass();
$template->id = $customcert->templateid;