Move creating the temp directory out of the emailing for loop (#238)

classes/task/email_certificate_task.php

@@ -154,16 +154,16 @@ class email_certificate_task extends \core\task\scheduled_task {
                 continue;
             }
 
-            // Now, email the people we need to.
-            foreach ($issuedusers as $user) {
-                $userfullname = fullname($user);
-
             // Create a directory to store the PDF we will be sending.
             $tempdir = make_temp_directory('certificate/attachment');
             if (!$tempdir) {
-                    return false;
+                return;
             }
 
+            // Now, email the people we need to.
+            foreach ($issuedusers as $user) {
+                $userfullname = fullname($user);
+
                 // Now, get the PDF.
                 $template = new \stdClass();
                 $template->id = $customcert->templateid;