KumiSystems/moodle-mod-customcert
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Removed boolean return and added a comment (#237)

Browse source
This commit is contained in:
Mark Nelson 2018-12-17 14:11:11 +08:00
parent 149e3cfc6c
commit 0771ec8a4b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
classes/task/email_certificate_task.php
View file

@ -62,7 +62,7 @@ class email_certificate_task extends \core\task\scheduled_task {
OR c.emailteachers = :emailteachers OR c.emailteachers = :emailteachers
OR $emailotherslengthsql >= 3)"; OR $emailotherslengthsql >= 3)";
if (!$customcerts = $DB->get_records_sql($sql, array('emailstudents' => 1, 'emailteachers' => 1))) { if (!$customcerts = $DB->get_records_sql($sql, array('emailstudents' => 1, 'emailteachers' => 1))) {
return false; return;
} }
// The renderers used for sending emails. // The renderers used for sending emails.
@ -149,11 +149,12 @@ class email_certificate_task extends \core\task\scheduled_task {
} }
} }
// Now, email the people we need to. // If there are no users to email we can return early.
if (!$issuedusers) { if (!$issuedusers) {
continue; continue;
} }
// Now, email the people we need to.
foreach ($issuedusers as $user) { foreach ($issuedusers as $user) {
$userfullname = fullname($user); $userfullname = fullname($user);