KumiSystems/moodle-auth_jwt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #101 from StudiUM/fix-unit-tests

Browse source 
Fix unit tests in auth_plugin_test.php
This commit is contained in:
Dmitrii Metelkin 2023-12-07 08:59:09 +11:00 committed by GitHub
commit 9c9266a826
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
tests/auth_plugin_test.php
View file

@ -45,6 +45,12 @@ class auth_plugin_test extends advanced_testcase {
*/ */
protected $user; protected $user;
/**
* Path used for the redirection.
* @var string
*/
const REDIRECTION_PATH = "/redirection";
/** /**
* Initial set up. * Initial set up.
*/ */
@ -392,7 +398,7 @@ class auth_plugin_test extends advanced_testcase {
self::getDataGenerator()->create_user($originaluser); self::getDataGenerator()->create_user($originaluser);
$duplicateuser = clone($originaluser); $duplicateuser = clone ($originaluser);
$duplicateuser->email = 'duplicateuser@test.com'; $duplicateuser->email = 'duplicateuser@test.com';
$this->expectException(invalid_parameter_exception::class); $this->expectException(invalid_parameter_exception::class);
@ -422,7 +428,7 @@ class auth_plugin_test extends advanced_testcase {
self::getDataGenerator()->create_user($originaluser); self::getDataGenerator()->create_user($originaluser);
$duplicateuser = clone($originaluser); $duplicateuser = clone ($originaluser);
$duplicateuser->username = 'duplicateuser'; $duplicateuser->username = 'duplicateuser';
$this->expectException(invalid_parameter_exception::class); $this->expectException(invalid_parameter_exception::class);
@ -1039,10 +1045,12 @@ class auth_plugin_test extends advanced_testcase {
* Test when try to logout, but user is not logged in. * Test when try to logout, but user is not logged in.
*/ */
public function test_user_logout_userkey_when_user_is_not_logged_in() { public function test_user_logout_userkey_when_user_is_not_logged_in() {
$_POST['return'] = 'http://google.com'; $_POST['return'] = self::REDIRECTION_PATH;
$this->expectException(moodle_exception::class); $this->expectException(moodle_exception::class);
$this->expectExceptionMessage('Unsupported redirect to http://google.com detected, execution terminated.'); $this->expectExceptionMessage(
sprintf("Unsupported redirect to %s detected, execution terminated.", self::REDIRECTION_PATH)
);
$this->auth->user_logout_userkey(); $this->auth->user_logout_userkey();
} }
@ -1053,7 +1061,7 @@ class auth_plugin_test extends advanced_testcase {
public function test_user_logout_userkey_when_user_logged_in_with_different_auth() { public function test_user_logout_userkey_when_user_logged_in_with_different_auth() {
global $USER; global $USER;
$_POST['return'] = 'http://google.com'; $_POST['return'] = self::REDIRECTION_PATH;
$this->setUser($this->user); $this->setUser($this->user);
try { try {
@ -1088,14 +1096,16 @@ class auth_plugin_test extends advanced_testcase {
$this->setUser($this->user); $this->setUser($this->user);
$USER->auth = 'userkey'; $USER->auth = 'userkey';
$_POST['return'] = 'http://google.com'; $_POST['return'] = self::REDIRECTION_PATH;
try { try {
$this->auth->user_logout_userkey(); $this->auth->user_logout_userkey();
} catch (moodle_exception $e) { } catch (moodle_exception $e) {
$this->assertFalse(isloggedin()); $this->assertFalse(isloggedin());
$this->assertEquals('Unsupported redirect to http://google.com detected, execution terminated.', $e->getMessage()); $this->assertEquals(
sprintf('Unsupported redirect to %s detected, execution terminated.', self::REDIRECTION_PATH),
$e->getMessage()
);
} }
} }
} }