KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: Improve memory usage in RemoveStaleNotificationsJob (#5271)

Browse source 
The job we introduced recently for removing the stale migrations would time out in instances with a large amount of deleted data.
So improving it for better memory utilization.
This commit is contained in:
Sojan Jose 2022-08-15 19:58:42 +05:30 committed by GitHub
parent 2397326324
commit ecb1f57efe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/jobs/migration/remove_stale_notifications_job.rb
View file

@ -12,9 +12,8 @@ class Migration::RemoveStaleNotificationsJob < ApplicationJob
deleted_ids = []
Message.unscoped.distinct.pluck(:inbox_id).each_slice(1000) do |id_list|
deleted_ids << (id_list - Inbox.where(id: id_list).pluck(:id))
end
deleted_ids = (id_list - Inbox.where(id: id_list).pluck(:id))
Message.where(inbox_id: deleted_ids.flatten).destroy_all
end
end
end