Codeclimate fixes

This commit is contained in:
Nithin David 2021-12-06 20:44:16 +05:30
parent 0f2f8a188b
commit e4f52fb183
4 changed files with 16 additions and 23 deletions

View file

@ -59,10 +59,10 @@ $badge-size: var(--space-normal);
$label-badge-size: var(--space-slab); $label-badge-size: var(--space-slab);
.badge { .badge {
border-radius: var(--border-radius-normal);
font-weight: var(--font-weight-bold);
height: min-content; height: min-content;
line-height: 1; line-height: 1;
font-weight: var(--font-weight-bold);
border-radius: var(--border-radius-normal);
&.small { &.small {
font-size: var(--font-size-nano); font-size: var(--font-size-nano);
@ -76,19 +76,19 @@ $label-badge-size: var(--space-slab);
&.secondary { &.secondary {
min-width: unset;
background: var(--s-75); background: var(--s-75);
color: var(--s-500); color: var(--s-500);
font-weight: var(--font-weight-bold); font-weight: var(--font-weight-bold);
min-width: unset;
} }
} }
.badge--label, .badge--label,
.badge--icon { .badge--icon {
display: inline-flex;
border-radius: var(--border-radius-small);
margin-right: var(--space-smaller);
background: var(--s-100); background: var(--s-100);
border-radius: var(--border-radius-small);
display: inline-flex;
margin-right: var(--space-smaller);
} }
.badge--icon { .badge--icon {
@ -104,8 +104,8 @@ $label-badge-size: var(--space-slab);
.badge--label { .badge--label {
height: $label-badge-size; height: $label-badge-size;
min-width: $label-badge-size;
margin-left: var(--space-smaller); margin-left: var(--space-smaller);
min-width: $label-badge-size;
} }

View file

@ -13,10 +13,10 @@
.conversation { .conversation {
@include flex; @include flex;
@include flex-shrink; @include flex-shrink;
padding: 0 var(--space-small);
margin: var(--space-small);
border-radius: var(--border-radius-large); border-radius: var(--border-radius-large);
cursor: pointer; cursor: pointer;
margin: var(--space-small);
padding: 0 var(--space-small);
position: relative; position: relative;
&.active { &.active {
@ -49,6 +49,7 @@
.conversation--message { .conversation--message {
color: $color-body; color: $color-body;
flex-grow: 0;
font-size: $font-size-small; font-size: $font-size-small;
font-weight: $font-weight-normal; font-weight: $font-weight-normal;
height: $space-medium; height: $space-medium;
@ -59,7 +60,6 @@
text-overflow: ellipsis; text-overflow: ellipsis;
white-space: nowrap; white-space: nowrap;
width: auto; width: auto;
flex-grow: 0;
} }
&.unread-chat { &.unread-chat {

View file

@ -21,8 +21,8 @@
a, a,
.button { .button {
@include position(relative, 1px null null null); @include position(relative, 1px null null null);
height: var(--space-large);
border-bottom: 2px solid transparent; border-bottom: 2px solid transparent;
height: var(--space-large);
transition: border-color .15s $swift-ease-out-function; transition: border-color .15s $swift-ease-out-function;
} }

View file

@ -23,19 +23,10 @@
{{ currentContact.name }} {{ currentContact.name }}
</h4> </h4>
<div class="conversation--metadata"> <div class="conversation--metadata">
<span <inbox-name v-if="showInboxName" :inbox="inbox" />
v-if="showInboxName"
:class="computedInboxClass"
class="badge small secondary badge--icon"
>
<fluent-icon
class="svg-icon"
:icon="computedInboxClass"
size="12"
/>
</span>
<thumbnail <thumbnail
v-if="showAssignee && assignee.name" v-if="showAssignee && assignee.name"
v-tooltip.top-end="assignee.name"
class="assignee-avatar" class="assignee-avatar"
:src="assignee.thumbnail" :src="assignee.thumbnail"
:username="assignee.name" :username="assignee.name"
@ -295,7 +286,7 @@ export default {
justify-content: space-between; justify-content: space-between;
.timestamp { .timestamp {
color: var(--s-600); color: var(--s-500);
font-size: var(--font-size-micro); font-size: var(--font-size-micro);
font-weight: var(--font-weight-normal); font-weight: var(--font-weight-normal);
line-height: var(--space-normal); line-height: var(--space-normal);
@ -349,6 +340,8 @@ export default {
font-weight: var(--font-weight-medium); font-weight: var(--font-weight-medium);
line-height: var(--space-slab); line-height: var(--space-slab);
padding: var(--space-micro) 0 var(--space-micro) 0; padding: var(--space-micro) 0 var(--space-micro) 0;
margin-bottom: 0;
margin-right: var(--space-smaller);
} }
.assignee-avatar { .assignee-avatar {