KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix #58 - Refactor inbox_members_controller (#109)

Browse source
This commit is contained in:
Anca 2019-10-08 11:33:41 +03:00 committed by Sojan Jose
parent eef7555d62
commit e066a9cff5
1 changed files with 49 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
app/controllers/api/v1/inbox_members_controller.rb
View file

@ -1,23 +1,20 @@
class Api::V1::InboxMembersController < Api::BaseController
module Api
module V1
class InboxMembersController < Api::BaseController
before_action :fetch_inbox, only: [:create, :show]
before_action :current_agents_ids, only: [:create]
def create #update also done via same action
#get all the user_ids which the inbox currently has as members.
#get the list of user_ids from params
#the missing ones are the agents which are to be deleted from the inbox
# the new ones are the agents which are to be added to the inbox
def create
# update also done via same action
if @inbox
begin
add_agents
remove_agents
update_agents_list
head :ok
rescue => e
render_could_not_create_error("Could not add agents to inbox")
rescue StandardError
render_could_not_create_error('Could not add agents to inbox')
end
else
render_not_found_error("Agents or inbox not found")
render_not_found_error('Agents or inbox not found')
end
end
@ -27,16 +24,14 @@ class Api::V1::InboxMembersController < Api::BaseController
private
def add_agents
agents_to_be_added_ids.each do |user_id|
@inbox.add_member(user_id)
end
end
def update_agents_list
# get all the user_ids which the inbox currently has as members.
# get the list of user_ids from params
# the missing ones are the agents which are to be deleted from the inbox
# the new ones are the agents which are to be added to the inbox
def remove_agents
agents_to_be_removed_ids.each do |user_id|
@inbox.remove_member(user)
end
agents_to_be_added_ids.each { |user_id| @inbox.add_member(user_id) }
agents_to_be_removed_ids.each { |_user_id| @inbox.remove_member(user) }
end
def agents_to_be_added_ids
@ -55,3 +50,5 @@ class Api::V1::InboxMembersController < Api::BaseController
@inbox = current_account.inboxes.find(params[:inbox_id])
end
end
end
end