KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: Handle the Twilio exception in sentry

Browse source 
Fix trying to extract the Sid from non created message.

Fixes #3029
This commit is contained in:
Tejaswini Chile 2021-09-21 23:02:45 +05:30 committed by GitHub
parent c504067e2b
commit dddab0bbce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/services/twilio/send_on_twilio_service.rb
View file

@ -9,9 +9,9 @@ class Twilio::SendOnTwilioService < Base::SendOnChannelService
begin begin
twilio_message = client.messages.create(**message_params) twilio_message = client.messages.create(**message_params)
rescue Twilio::REST::TwilioError => e rescue Twilio::REST::TwilioError => e
Rails.logger.info "Twilio Error: #{e.message}" Sentry.capture_exception(e)
end end
message.update!(source_id: twilio_message.sid) message.update!(source_id: twilio_message.sid) if twilio_message
end end
def message_params def message_params

2
spec/services/twilio/send_on_twilio_service_spec.rb
View file

@ -28,6 +28,7 @@ describe Twilio::SendOnTwilioService do
message = create(:message, message_type: 'outgoing', private: true, inbox: twilio_inbox, account: account) message = create(:message, message_type: 'outgoing', private: true, inbox: twilio_inbox, account: account)
::Twilio::SendOnTwilioService.new(message: message).perform ::Twilio::SendOnTwilioService.new(message: message).perform
expect(twilio_client).not_to have_received(:messages) expect(twilio_client).not_to have_received(:messages)
expect(message.reload.source_id).to be_nil
end end
it 'if inbox channel is not twilio' do it 'if inbox channel is not twilio' do
@ -40,6 +41,7 @@ describe Twilio::SendOnTwilioService do
message = create(:message, message_type: 'incoming', inbox: twilio_inbox, account: account) message = create(:message, message_type: 'incoming', inbox: twilio_inbox, account: account)
::Twilio::SendOnTwilioService.new(message: message).perform ::Twilio::SendOnTwilioService.new(message: message).perform
expect(twilio_client).not_to have_received(:messages) expect(twilio_client).not_to have_received(:messages)
expect(message.reload.source_id).to be_nil
end end
it 'if message has an source id' do it 'if message has an source id' do