From d5ddc9d76c571784c35247a7963dcfc2a33e8be6 Mon Sep 17 00:00:00 2001
From: "Aswin Dev P.S" <aswindevps@gmail.com>
Date: Thu, 23 Jun 2022 02:39:04 +0530
Subject: [PATCH] chore: Fix SMTP sentry issue (#4883)

* Fix SMTP sentry issue
---
 .../dashboard/i18n/locale/en/inboxMgmt.json     |  3 ++-
 .../dashboard/settings/inbox/Settings.vue       | 11 ++++++++++-
 app/javascript/shared/helpers/Validators.js     |  1 +
 app/models/inbox.rb                             |  2 +-
 ...remove_special_characters_from_inbox_name.rb | 17 +++++++++++++++++
 db/schema.rb                                    |  2 +-
 6 files changed, 32 insertions(+), 4 deletions(-)
 create mode 100644 db/migrate/20220616154502_remove_special_characters_from_inbox_name.rb

diff --git a/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json b/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
index 54e69c304..c705b2b41 100644
--- a/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
+++ b/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
@@ -30,7 +30,8 @@
     "ADD": {
       "CHANNEL_NAME": {
         "LABEL": "Inbox Name",
-        "PLACEHOLDER": "Enter your inbox name (eg: Acme Inc)"
+        "PLACEHOLDER": "Enter your inbox name (eg: Acme Inc)",
+        "ERROR": "Please enter a valid inbox name"
       },
       "WEBSITE_NAME": {
         "LABEL": "Website Name",
diff --git a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
index 8c32159f2..acf6c4d74 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
@@ -30,8 +30,15 @@
         <woot-input
           v-model.trim="selectedInboxName"
           class="medium-9 columns settings-item"
+          :class="{ error: $v.selectedInboxName.$error }"
           :label="inboxNameLabel"
           :placeholder="inboxNamePlaceHolder"
+          :error="
+            $v.selectedInboxName.$error
+              ? $t('INBOX_MGMT.ADD.CHANNEL_NAME.ERROR')
+              : ''
+          "
+          @blur="$v.selectedInboxName.$touch"
         />
         <label
           v-if="isATwitterInbox"
@@ -293,6 +300,7 @@
         <woot-submit-button
           v-else
           type="submit"
+          :disabled="$v.$invalid"
           :button-text="$t('INBOX_MGMT.SETTINGS_POPUP.UPDATE')"
           :loading="uiFlags.isUpdatingInbox"
           @click="updateInbox"
@@ -318,7 +326,7 @@
 
 <script>
 import { mapGetters } from 'vuex';
-import { shouldBeUrl } from 'shared/helpers/Validators';
+import { shouldBeUrl, isValidName } from 'shared/helpers/Validators';
 import configMixin from 'shared/mixins/configMixin';
 import alertMixin from 'shared/mixins/alertMixin';
 import SettingIntroBanner from 'dashboard/components/widgets/SettingIntroBanner';
@@ -563,6 +571,7 @@ export default {
     webhookUrl: {
       shouldBeUrl,
     },
+    selectedInboxName: { isValidName },
   },
 };
 </script>
diff --git a/app/javascript/shared/helpers/Validators.js b/app/javascript/shared/helpers/Validators.js
index 993524fc9..d95dac615 100644
--- a/app/javascript/shared/helpers/Validators.js
+++ b/app/javascript/shared/helpers/Validators.js
@@ -16,3 +16,4 @@ export const isValidPassword = value => {
     containsSpecialCharacter
   );
 };
+export const isValidName = value => /^\b[\w\s]*\b$/.test(value);
diff --git a/app/models/inbox.rb b/app/models/inbox.rb
index b58e6870a..929b327e4 100644
--- a/app/models/inbox.rb
+++ b/app/models/inbox.rb
@@ -33,7 +33,7 @@ class Inbox < ApplicationRecord
   include Avatarable
   include OutOfOffisable
 
-  validates :name, presence: true
+  validates :name, presence: true, format: { with: /^\b[\w\s]*\b$/, multiline: true }
   validates :account_id, presence: true
   validates :timezone, inclusion: { in: TZInfo::Timezone.all_identifiers }
   validate :ensure_valid_max_assignment_limit
diff --git a/db/migrate/20220616154502_remove_special_characters_from_inbox_name.rb b/db/migrate/20220616154502_remove_special_characters_from_inbox_name.rb
new file mode 100644
index 000000000..0794250d1
--- /dev/null
+++ b/db/migrate/20220616154502_remove_special_characters_from_inbox_name.rb
@@ -0,0 +1,17 @@
+class RemoveSpecialCharactersFromInboxName < ActiveRecord::Migration[6.1]
+  def change
+    remove_special_characters_from_inbox_name
+  end
+
+  private
+
+  def remove_special_characters_from_inbox_name
+    ::Inbox.find_in_batches do |inbox_batch|
+      Rails.logger.info "Migrated till #{inbox_batch.first.id}\n"
+      inbox_batch.each do |inbox|
+        inbox.name = inbox.name.gsub(/[^\w\s_]/, '')
+        inbox.save!
+      end
+    end
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 6ab2179d3..43f616ada 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2022_06_10_091206) do
+ActiveRecord::Schema.define(version: 2022_06_16_154502) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_stat_statements"