KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: Audio notification would not work without action on the dashboard (#4303)

Browse source 
* fixes: Audio notification would not work without an action on dashboard

* fixes spec

* Minor fixes

* Minor fixes

* Review fixes

Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
This commit is contained in:
Sivin Varghese 2022-04-07 10:23:18 +05:30 • committed by GitHub
parent 8482ecc1b1
commit d4a046a21e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/javascript/shared/helpers/AudioNotificationHelper.js
View file

@ -3,7 +3,7 @@ import { IFrameHelper } from 'widget/helpers/utils';
import { showBadgeOnFavicon } from './faviconHelper'; import { showBadgeOnFavicon } from './faviconHelper';
export const initOnEvents = ['click', 'touchstart', 'keypress']; export const initOnEvents = ['click', 'touchstart', 'keypress', 'keydown'];
export const getAlertAudio = async (baseUrl = '') => { export const getAlertAudio = async (baseUrl = '') => {
const audioCtx = new (window.AudioContext || window.webkitAudioContext)(); const audioCtx = new (window.AudioContext || window.webkitAudioContext)();
const playsound = audioBuffer => { const playsound = audioBuffer => {
@ -53,6 +53,10 @@ export const shouldPlayAudio = (
message_type: messageType, message_type: messageType,
private: isPrivate, private: isPrivate,
} = message; } = message;
if (!isDocHidden && messageType === MESSAGE_TYPE.INCOMING) {
showBadgeOnFavicon();
return false;
}
const isFromCurrentUser = userId === senderId; const isFromCurrentUser = userId === senderId;
const playAudio = const playAudio =

2
app/javascript/shared/helpers/specs/AudioNotificationHelper.spec.js
View file

@ -17,7 +17,7 @@ describe('shouldPlayAudio', () => {
message_type: 0, message_type: 0,
private: false, private: false,
}; };
const [conversationId, userId, isDocHiddden] = [1, 2, false]; const [conversationId, userId, isDocHiddden] = [1, 2, true];
const result = shouldPlayAudio( const result = shouldPlayAudio(
message, message,
conversationId, conversationId,