KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: Do not enqueue job if it is already enqueued (#5068)

Browse source
This commit is contained in:
Pranav Raj S 2022-07-19 21:12:31 +05:30 committed by GitHub
parent 7fc0d166e8
commit cd5e0c548c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
enterprise/app/controllers/enterprise/api/v1/accounts_controller.rb
View file

@ -3,7 +3,10 @@ class Enterprise::Api::V1::AccountsController < Api::BaseController
before_action :check_authorization
def subscription
Enterprise::CreateStripeCustomerJob.perform_later(@account) if stripe_customer_id.blank?
if stripe_customer_id.blank? && @account.custom_attributes['is_creating_customer'].blank?
@account.update(custom_attributes: { is_creating_customer: true })
Enterprise::CreateStripeCustomerJob.perform_later(@account)
end
head :no_content
end

11
spec/enterprise/controllers/enterprise/api/v1/accounts_controller_spec.rb
View file

@ -32,6 +32,17 @@ RSpec.describe 'Enterprise Billing APIs', type: :request do
headers: admin.create_new_auth_token,
as: :json
end.to have_enqueued_job(Enterprise::CreateStripeCustomerJob).with(account)
expect(account.reload.custom_attributes).to eq({ 'is_creating_customer': true }.with_indifferent_access)
end
it 'does not enqueue a job if a job is already enqueued' do
account.update!(custom_attributes: { is_creating_customer: true })
expect do
post "/enterprise/api/v1/accounts/#{account.id}/subscription",
headers: admin.create_new_auth_token,
as: :json
end.not_to have_enqueued_job(Enterprise::CreateStripeCustomerJob).with(account)
end
it 'does not enqueues a job if customer id is present' do