From 01cc3d7c9c59c05948fece4b3bcc1d8c8d743414 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 6 Dec 2022 12:49:00 -0800 Subject: [PATCH 1/2] chore(deps): bump qs from 6.5.2 to 6.5.3 (#6028) Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index 4d92bce97..e81ffabcb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -12962,9 +12962,9 @@ qs@^6.10.0: side-channel "^1.0.4" qs@~6.5.2: - version "6.5.2" - resolved "https://registry.yarnpkg.com/qs/-/qs-6.5.2.tgz#cb3ae806e8740444584ef154ce8ee98d403f3e36" - integrity sha512-N5ZAX4/LxJmF+7wN74pUD6qAh9/wnvdQcjq9TZjevvXzSUo7bfmw91saqMjzGS2xq91/odN2dW/WOl7qQHNDGA== + version "6.5.3" + resolved "https://registry.yarnpkg.com/qs/-/qs-6.5.3.tgz#3aeeffc91967ef6e35c0e488ef46fb296ab76aad" + integrity sha512-qxXIEh4pCGfHICj1mAJQ2/2XVZkjCDTcEgfoSQxc/fYivUZxTkk7L3bDBJSoNrEzXI17oUO5Dp07ktqE5KzczA== query-string@^4.1.0: version "4.3.4" From f1d1bb84fda61afe5b44f361d8a0a7eb79e11ec3 Mon Sep 17 00:00:00 2001 From: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Date: Wed, 7 Dec 2022 12:00:51 +0530 Subject: [PATCH 2/2] fix: Filters are not applied unless I'm on the All Conversations screen (#6006) * fix: Filters are not applied unless I'm on the All Conversations screen * chore: Review fixes * chore: Minor sidebar fixes * chore: Review fixes Co-authored-by: Pranav Raj S --- app/javascript/dashboard/components/ChatList.vue | 6 +++--- .../layout/sidebarComponents/SecondaryChildNavItem.vue | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/javascript/dashboard/components/ChatList.vue b/app/javascript/dashboard/components/ChatList.vue index 23fefb8ff..a957ff78b 100644 --- a/app/javascript/dashboard/components/ChatList.vue +++ b/app/javascript/dashboard/components/ChatList.vue @@ -345,6 +345,9 @@ export default { }; }, pageTitle() { + if (this.hasAppliedFilters) { + return this.$t('CHAT_LIST.TAB_HEADING'); + } if (this.inbox.name) { return this.inbox.name; } @@ -439,9 +442,6 @@ export default { }, methods: { onApplyFilter(payload) { - if (this.$route.name !== 'home') { - this.$router.push({ name: 'home' }); - } this.resetBulkActions(); this.foldersQuery = filterQueryGenerator(payload); this.$store.dispatch('conversationPage/reset'); diff --git a/app/javascript/dashboard/components/layout/sidebarComponents/SecondaryChildNavItem.vue b/app/javascript/dashboard/components/layout/sidebarComponents/SecondaryChildNavItem.vue index 2dd23544f..cb5c52c76 100644 --- a/app/javascript/dashboard/components/layout/sidebarComponents/SecondaryChildNavItem.vue +++ b/app/javascript/dashboard/components/layout/sidebarComponents/SecondaryChildNavItem.vue @@ -112,6 +112,7 @@ $label-badge-size: var(--space-slab); padding: var(--space-smaller) var(--space-smaller); margin: var(--space-smaller) 0; text-align: left; + line-height: 1.2; &:hover { background: var(--s-25); @@ -135,8 +136,6 @@ $label-badge-size: var(--space-slab); .menu-label { flex-grow: 1; - display: inline-flex; - align-items: center; } .inbox-icon {