Update contact_params function (#100)

removed if block,
cannot be shortened further due to exception handling and params formatting
This commit is contained in:
Marc C 2019-10-06 15:29:54 +08:00 committed by Sojan Jose
parent 84e0eb2441
commit 9b9aee4657

View file

@ -126,22 +126,18 @@ Assumptions
end end
def contact_params def contact_params
if @inbox.facebook?
k = Koala::Facebook::API.new(@inbox.channel.page_access_token)
begin begin
result = k.get_object(@sender_id) k = Koala::Facebook::API.new(@inbox.channel.page_access_token) if @inbox.facebook?
rescue => e result = k.get_object(@sender_id) || {}
rescue Exception => e
result = {} result = {}
Raven.capture_exception(e) Raven.capture_exception(e)
end end
photo_url = result["profile_pic"] || nil params = {
params = name: "#{result['first_name'] || 'John'} #{result['last_name'] || 'Doe'}",
{
name: (result["first_name"] || "John" )<< " " << (result["last_name"] || "Doe"),
account_id: @inbox.account_id, account_id: @inbox.account_id,
source_id: @sender_id, source_id: @sender_id,
remote_avatar_url: photo_url remote_avatar_url: result['profile_pic'] || nil
} }
end end
end end
end