From 9984edd3ef357af8df8d61357910cdc02b2af477 Mon Sep 17 00:00:00 2001
From: Tejaswini Chile <tejaswini@chatwoot.com>
Date: Thu, 16 Dec 2021 00:24:50 +0530
Subject: [PATCH] Feat: Manage conversation for tweets based on the tweet flag
 (#3353)

Add tweet conversation only if tweets are enabled.

Fixes #1961
---
 .../api/v1/accounts/inboxes_controller.rb     | 15 +-----------
 .../dashboard/i18n/locale/en/inboxMgmt.json   |  5 +++-
 .../dashboard/settings/inbox/Settings.vue     | 11 +++++++++
 app/models/channel/twitter_profile.rb         |  3 +++
 app/models/inbox.rb                           |  4 ++++
 app/services/twitter/tweet_parser_service.rb  |  7 +++++-
 app/views/api/v1/models/_inbox.json.jbuilder  |  2 ++
 ...d_tweet_enabled_flag_to_twitter_channel.rb |  5 ++++
 db/schema.rb                                  |  1 +
 lib/webhooks/twitter.rb                       |  1 +
 .../v1/accounts/inboxes_controller_spec.rb    | 13 +++++++++++
 spec/lib/webhooks/twitter_spec.rb             | 23 ++++++++++++++++++-
 12 files changed, 73 insertions(+), 17 deletions(-)
 create mode 100644 db/migrate/20211109143122_add_tweet_enabled_flag_to_twitter_channel.rb

diff --git a/app/controllers/api/v1/accounts/inboxes_controller.rb b/app/controllers/api/v1/accounts/inboxes_controller.rb
index 0c80d9983..463a08bfb 100644
--- a/app/controllers/api/v1/accounts/inboxes_controller.rb
+++ b/app/controllers/api/v1/accounts/inboxes_controller.rb
@@ -124,19 +124,6 @@ class Api::V1::Accounts::InboxesController < Api::V1::Accounts::BaseController
   end
 
   def get_channel_attributes(channel_type)
-    case channel_type
-    when 'Channel::WebWidget'
-      Channel::WebWidget::EDITABLE_ATTRS
-    when 'Channel::Api'
-      Channel::Api::EDITABLE_ATTRS
-    when 'Channel::Email'
-      Channel::Email::EDITABLE_ATTRS
-    when 'Channel::Telegram'
-      Channel::Telegram::EDITABLE_ATTRS
-    when 'Channel::Line'
-      Channel::Line::EDITABLE_ATTRS
-    else
-      []
-    end
+    channel_type.constantize::EDITABLE_ATTRS.presence || []
   end
 end
diff --git a/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json b/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
index 774c8160d..b64362027 100644
--- a/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
+++ b/app/javascript/dashboard/i18n/locale/en/inboxMgmt.json
@@ -47,7 +47,10 @@
       },
       "TWITTER": {
         "HELP": "To add your Twitter profile as a channel, you need to authenticate your Twitter Profile by clicking on 'Sign in with Twitter' ",
-        "ERROR_MESSAGE": "There was an error connecting to Twitter, please try again"
+        "ERROR_MESSAGE": "There was an error connecting to Twitter, please try again",
+        "TWEETS": {
+          "ENABLE": "Create conversations from mentioned Tweets"
+        }
       },
       "WEBSITE_CHANNEL": {
         "TITLE": "Website channel",
diff --git a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
index 7c8db94d5..ac54dac85 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue
@@ -32,6 +32,14 @@
           :label="inboxNameLabel"
           :placeholder="inboxNamePlaceHolder"
         />
+        <label for="toggle-business-hours" class="toggle-input-wrap" v-if="isATwitterInbox">
+          <input
+            v-model="tweetsEnabled"
+            type="checkbox"
+            name="toggle-business-hours"
+          />
+          {{ $t('INBOX_MGMT.ADD.TWITTER.TWEETS.ENABLE') }}
+        </label>
         <woot-input
           v-if="isAPIInbox"
           v-model.trim="webhookUrl"
@@ -401,6 +409,7 @@ export default {
       avatarUrl: '',
       selectedAgents: [],
       greetingEnabled: true,
+      tweetsEnabled: true,
       hmacMandatory: null,
       greetingMessage: '',
       autoAssignment: false,
@@ -564,6 +573,7 @@ export default {
         this.selectedInboxName = this.inbox.name;
         this.webhookUrl = this.inbox.webhook_url;
         this.greetingEnabled = this.inbox.greeting_enabled || false;
+        this.tweetsEnabled = this.inbox.tweets_enabled || false;
         this.hmacMandatory = this.inbox.hmac_mandatory || false;
         this.greetingMessage = this.inbox.greeting_message || '';
         this.autoAssignment = this.inbox.enable_auto_assignment;
@@ -622,6 +632,7 @@ export default {
             selectedFeatureFlags: this.selectedFeatureFlags,
             reply_time: this.replyTime || 'in_a_few_minutes',
             hmac_mandatory: this.hmacMandatory,
+            tweets_enabled: this.tweetsEnabled,
           },
         };
         if (this.avatarFile) {
diff --git a/app/models/channel/twitter_profile.rb b/app/models/channel/twitter_profile.rb
index ff2b7c19d..baf3b992e 100644
--- a/app/models/channel/twitter_profile.rb
+++ b/app/models/channel/twitter_profile.rb
@@ -3,6 +3,7 @@
 # Table name: channel_twitter_profiles
 #
 #  id                          :bigint           not null, primary key
+#  tweets_enabled              :boolean          default(TRUE)
 #  twitter_access_token        :string           not null
 #  twitter_access_token_secret :string           not null
 #  created_at                  :datetime         not null
@@ -24,6 +25,8 @@ class Channel::TwitterProfile < ApplicationRecord
 
   before_destroy :unsubscribe
 
+  EDITABLE_ATTRS = [:tweets_enabled].freeze
+
   def name
     'Twitter'
   end
diff --git a/app/models/inbox.rb b/app/models/inbox.rb
index ba85c9e64..f16a5ca92 100644
--- a/app/models/inbox.rb
+++ b/app/models/inbox.rb
@@ -87,6 +87,10 @@ class Inbox < ApplicationRecord
     channel_type == 'Channel::TwilioSms'
   end
 
+  def twitter?
+    channel_type == 'Channel::TwitterProfile'
+  end
+
   def inbox_type
     channel.name
   end
diff --git a/app/services/twitter/tweet_parser_service.rb b/app/services/twitter/tweet_parser_service.rb
index d6256c25d..82664ea5f 100644
--- a/app/services/twitter/tweet_parser_service.rb
+++ b/app/services/twitter/tweet_parser_service.rb
@@ -3,7 +3,8 @@ class Twitter::TweetParserService < Twitter::WebhooksBaseService
 
   def perform
     set_inbox
-    return if message_already_exist? || user_has_blocked?
+
+    return if !tweets_enabled? || message_already_exist? || user_has_blocked?
 
     create_message
   end
@@ -38,6 +39,10 @@ class Twitter::TweetParserService < Twitter::WebhooksBaseService
     payload['user_has_blocked'] == true
   end
 
+  def tweets_enabled?
+    @inbox.channel.tweets_enabled?
+  end
+
   def parent_tweet_id
     tweet_data['in_reply_to_status_id_str'].nil? ? tweet_data['id'].to_s : tweet_data['in_reply_to_status_id_str']
   end
diff --git a/app/views/api/v1/models/_inbox.json.jbuilder b/app/views/api/v1/models/_inbox.json.jbuilder
index e4bdbcc66..f76b8566d 100644
--- a/app/views/api/v1/models/_inbox.json.jbuilder
+++ b/app/views/api/v1/models/_inbox.json.jbuilder
@@ -14,6 +14,8 @@ json.working_hours resource.weekly_schedule
 json.timezone resource.timezone
 json.callback_webhook_url resource.callback_webhook_url
 
+json.tweets_enabled resource.channel.try(:tweets_enabled) if resource.twitter?
+
 ## Channel specific settings
 ## TODO : Clean up and move the attributes into channel sub section
 
diff --git a/db/migrate/20211109143122_add_tweet_enabled_flag_to_twitter_channel.rb b/db/migrate/20211109143122_add_tweet_enabled_flag_to_twitter_channel.rb
new file mode 100644
index 000000000..02846a2c9
--- /dev/null
+++ b/db/migrate/20211109143122_add_tweet_enabled_flag_to_twitter_channel.rb
@@ -0,0 +1,5 @@
+class AddTweetEnabledFlagToTwitterChannel < ActiveRecord::Migration[6.1]
+  def change
+    add_column :channel_twitter_profiles, :tweets_enabled, :boolean, default: true
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 80e526555..cbc9e2fae 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -242,6 +242,7 @@ ActiveRecord::Schema.define(version: 2021_12_08_085931) do
     t.integer "account_id", null: false
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.boolean "tweets_enabled", default: true
     t.index ["account_id", "profile_id"], name: "index_channel_twitter_profiles_on_account_id_and_profile_id", unique: true
   end
 
diff --git a/lib/webhooks/twitter.rb b/lib/webhooks/twitter.rb
index 4ee0badfe..7475bf3fc 100644
--- a/lib/webhooks/twitter.rb
+++ b/lib/webhooks/twitter.rb
@@ -2,6 +2,7 @@
 
 class Webhooks::Twitter
   SUPPORTED_EVENTS = [:direct_message_events, :tweet_create_events].freeze
+  EDITABLE_ATTRS = [:tweets_enabled].freeze
 
   attr_accessor :params, :account
 
diff --git a/spec/controllers/api/v1/accounts/inboxes_controller_spec.rb b/spec/controllers/api/v1/accounts/inboxes_controller_spec.rb
index 9fdceac6f..ea28dcbd5 100644
--- a/spec/controllers/api/v1/accounts/inboxes_controller_spec.rb
+++ b/spec/controllers/api/v1/accounts/inboxes_controller_spec.rb
@@ -362,6 +362,19 @@ RSpec.describe 'Inboxes API', type: :request do
         expect(api_channel.reload.webhook_url).to eq('webhook.test')
       end
 
+      it 'updates twitter inbox when administrator' do
+        api_channel = create(:channel_twitter_profile, account: account, tweets_enabled: true)
+        api_inbox = create(:inbox, channel: api_channel, account: account)
+
+        patch "/api/v1/accounts/#{account.id}/inboxes/#{api_inbox.id}",
+              headers: admin.create_new_auth_token,
+              params: { channel: { tweets_enabled: false } },
+              as: :json
+
+        expect(response).to have_http_status(:success)
+        expect(api_channel.reload.tweets_enabled).to eq(false)
+      end
+
       it 'updates email inbox when administrator' do
         email_channel = create(:channel_email, account: account)
         email_inbox = create(:inbox, channel: email_channel, account: account)
diff --git a/spec/lib/webhooks/twitter_spec.rb b/spec/lib/webhooks/twitter_spec.rb
index a653fdc6b..74820c609 100644
--- a/spec/lib/webhooks/twitter_spec.rb
+++ b/spec/lib/webhooks/twitter_spec.rb
@@ -6,7 +6,7 @@ describe Webhooks::Twitter do
 
   let!(:account) { create(:account) }
   # FIX ME: recipient id is set to 1 inside event factories
-  let!(:twitter_channel) { create(:channel_twitter_profile, account: account, profile_id: '1') }
+  let!(:twitter_channel) { create(:channel_twitter_profile, account: account, profile_id: '1', tweets_enabled: true) }
   let!(:twitter_inbox) { create(:inbox, channel: twitter_channel, account: account, greeting_enabled: false) }
   let!(:dm_params) { build(:twitter_message_create_event).with_indifferent_access }
   let!(:tweet_params) { build(:tweet_create_event).with_indifferent_access }
@@ -32,6 +32,27 @@ describe Webhooks::Twitter do
 
       it 'creates incoming message in the twitter inbox' do
         twitter_webhook.new(tweet_params).consume
+        twitter_inbox.reload
+        expect(twitter_inbox.contacts.count).to be 1
+        expect(twitter_inbox.conversations.count).to be 1
+        expect(twitter_inbox.messages.count).to be 1
+      end
+    end
+
+    context 'with tweet_enabled flag disabled' do
+      before do
+        twitter_channel.update(tweets_enabled: false)
+      end
+
+      it 'does not create incoming message in the twitter inbox for tweet' do
+        twitter_webhook.new(tweet_params).consume
+        expect(twitter_inbox.contacts.count).to be 0
+        expect(twitter_inbox.conversations.count).to be 0
+        expect(twitter_inbox.messages.count).to be 0
+      end
+
+      it 'creates incoming message in the twitter inbox' do
+        twitter_webhook.new(dm_params).consume
         expect(twitter_inbox.contacts.count).to be 1
         expect(twitter_inbox.conversations.count).to be 1
         expect(twitter_inbox.messages.count).to be 1