From 7f8204a9dad3e907646085519e455e206fcbd568 Mon Sep 17 00:00:00 2001 From: Fayaz Ahmed <15716057+fayazara@users.noreply.github.com> Date: Tue, 23 Nov 2021 09:42:47 +0530 Subject: [PATCH] fix: Required check for Conversation filters (#3442) --- .../conversation/ConversationAdvancedFilter.vue | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/javascript/dashboard/components/widgets/conversation/ConversationAdvancedFilter.vue b/app/javascript/dashboard/components/widgets/conversation/ConversationAdvancedFilter.vue index 42186f21e..288b7cc1f 100644 --- a/app/javascript/dashboard/components/widgets/conversation/ConversationAdvancedFilter.vue +++ b/app/javascript/dashboard/components/widgets/conversation/ConversationAdvancedFilter.vue @@ -66,13 +66,10 @@ export default { $each: { values: { required: requiredIf(prop => { - let userInputRequired = true; - if ( - prop.filter_operator !== 'is_present' || - prop.filter_operator !== 'is_not_present' - ) - userInputRequired = false; - return userInputRequired; + return !( + prop.filter_operator === 'is_present' || + prop.filter_operator === 'is_not_present' + ); }), }, },