Review fixes

This commit is contained in:
Nithin David 2022-11-08 17:41:16 -08:00
parent 39c63cf56f
commit 655d15f999
4 changed files with 7 additions and 21 deletions

View file

@ -353,7 +353,7 @@ export default {
return this.$t('CHAT_LIST.MENTION_HEADING');
}
if (this.conversationType === 'participating') {
return 'Participating';
return this.$t('CONVERSATION_WATCHERS.SIDEBAR_MENU_TITLE');
}
if (this.hasActiveFolders) {
return this.activeFolder.name;

View file

@ -241,6 +241,7 @@
"SUBJECT": "Subject"
},
"CONVERSATION_WATCHERS": {
"SIDEBAR_MENU_TITLE": "Participating",
"SIDEBAR_TITLE": "Conversation watchers",
"NO_RECORDS_FOUND": "No results found",
"ADD_WATCHERS": "Select watchers",

View file

@ -1,6 +1,6 @@
<template>
<div class="subscribers-wrap">
<div class="subscribers--collapsed">
<div class="watchers-wrap">
<div class="watchers--collapsed">
<div class="content-wrap">
<div>
<p v-if="watchersList.length" class="total-watchers message-text">
@ -222,7 +222,7 @@ export default {
};
</script>
<style lang="scss">
.subscribers-wrap {
.watchers-wrap {
position: relative;
}
@ -233,22 +233,7 @@ export default {
margin-bottom: var(--space-smaller);
}
.watcher-wrap {
display: inline-flex;
align-items: center;
width: auto;
padding: 1px;
padding-left: 5px;
border-radius: var(--space-one);
background: var(--s-50);
margin: 4px 5px 5px 0px;
p {
margin-bottom: var(--zero);
}
}
.subscribers--collapsed {
.watchers--collapsed {
display: flex;
justify-content: space-between;
}

View file

@ -7,7 +7,7 @@
"eslint:fix": "eslint app/**/*.{js,vue} --fix",
"pretest": "rimraf .jest-cache",
"test": "jest -w 1 --no-cache",
"test:watch": "jest -w 1 --watch",
"test:watch": "jest -w 1 --watch --no-cache",
"test:coverage": "jest -w 1 --no-cache --collectCoverage",
"webpacker-start": "webpack-dev-server -d --config webpack.dev.config.js --content-base public/ --progress --colors",
"start:dev": "foreman start -f ./Procfile.dev",