KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: Unescape Slack incoming messages (#2604)

Browse source
This commit is contained in:
Pranav Raj S 2021-07-09 17:45:02 +05:30 committed by GitHub
parent a9ccded62b
commit 5726447e47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/integrations/slack/incoming_message_builder.rb
View file

@ -83,7 +83,7 @@ class Integrations::Slack::IncomingMessageBuilder
message_type: :outgoing, message_type: :outgoing,
account_id: conversation.account_id, account_id: conversation.account_id,
inbox_id: conversation.inbox_id, inbox_id: conversation.inbox_id,
content: params[:event][:text], content: Slack::Messages::Formatting.unescape(params[:event][:text] || ''),
external_source_id_slack: params[:event][:ts], external_source_id_slack: params[:event][:ts],
private: private_note?, private: private_note?,
sender: sender sender: sender

1
spec/lib/integrations/slack/incoming_message_builder_spec.rb
View file

@ -33,6 +33,7 @@ describe Integrations::Slack::IncomingMessageBuilder do
allow(builder).to receive(:sender).and_return(nil) allow(builder).to receive(:sender).and_return(nil)
builder.perform builder.perform
expect(conversation.messages.count).to eql(messages_count + 1) expect(conversation.messages.count).to eql(messages_count + 1)
expect(conversation.messages.last.content).to eql('this is test https://chatwoot.com Hey @Sojan Test again')
end end
it 'does not create message for invalid event type' do it 'does not create message for invalid event type' do

2
spec/support/slack_stubs.rb
View file

@ -46,7 +46,7 @@ module SlackStubs
{ {
"client_msg_id": 'ffc6e64e-6f0c-4a3d-b594-faa6b44e48ab', "client_msg_id": 'ffc6e64e-6f0c-4a3d-b594-faa6b44e48ab',
"type": 'message', "type": 'message',
"text": 'this is test', "text": 'this is test <https://chatwoot.com> Hey <@U019KT237LP|Sojan> Test again',
"user": 'ULYPAKE5S', "user": 'ULYPAKE5S',
"ts": '1588623033.006000', "ts": '1588623033.006000',
"team": 'TLST3048H', "team": 'TLST3048H',