feat: Adds the ability to add new locale in portal (#5363)

This commit is contained in:
Muhsin Keloth 2022-09-01 22:19:30 +05:30 committed by GitHub
parent 7f3f6f7129
commit 504d339dd7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 193 additions and 206 deletions

View file

@ -6,8 +6,8 @@ class PortalsAPI extends ApiClient {
super('portals', { accountScoped: true }); super('portals', { accountScoped: true });
} }
updatePortal({ portalSlug, params }) { updatePortal({ portalSlug, portalObj }) {
return axios.patch(`${this.url}/${portalSlug}`, params); return axios.patch(`${this.url}/${portalSlug}`, portalObj);
} }
deletePortal(portalSlug) { deletePortal(portalSlug) {

View file

@ -5,10 +5,6 @@
{{ $t(`SIDEBAR.${menuItem.label}`) }} {{ $t(`SIDEBAR.${menuItem.label}`) }}
</span> </span>
<div v-if="isHelpCenterSidebar" class="submenu-icons"> <div v-if="isHelpCenterSidebar" class="submenu-icons">
<!-- Hidden since this is in V2
<div class="submenu-icon">
<fluent-icon icon="search" size="16" />
</div> -->
<div class="submenu-icon" @click="onClickOpen"> <div class="submenu-icon" @click="onClickOpen">
<fluent-icon icon="add" size="16" /> <fluent-icon icon="add" size="16" />
</div> </div>

View file

@ -210,6 +210,24 @@
"ERROR_MESSAGE_FOR_BASIC": "Couldn't create the portal. Try again.", "ERROR_MESSAGE_FOR_BASIC": "Couldn't create the portal. Try again.",
"ERROR_MESSAGE_FOR_UPDATE": "Couldn't update the portal. Try again." "ERROR_MESSAGE_FOR_UPDATE": "Couldn't update the portal. Try again."
} }
},
"ADD_LOCALE": {
"TITLE": "Add a new locale",
"SUB_TITLE": "This adds a new locale to your available translation list.",
"PORTAL": "Portal",
"LOCALE": {
"LABEL": "Locale",
"PLACEHOLDER": "Choose a locale",
"ERROR": "Locale is required"
},
"BUTTONS": {
"CREATE": "Create locale",
"CANCEL": "Cancel"
},
"API": {
"SUCCESS_MESSAGE": "Locale added successfully",
"ERROR_MESSAGE": "Unable to add locale. Try again."
}
} }
}, },
"TABLE": { "TABLE": {

View file

@ -0,0 +1,137 @@
<template>
<modal :show.sync="show" :on-close="onClose">
<woot-modal-header
:header-title="$t('HELP_CENTER.PORTAL.ADD_LOCALE.TITLE')"
:header-content="$t('HELP_CENTER.PORTAL.ADD_LOCALE.SUB_TITLE')"
/>
<form class="row" @submit.prevent="onCreate">
<div class="medium-12 columns">
<label :class="{ error: $v.selectedLocale.$error }">
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.LOCALE.LABEL') }}
<select v-model="selectedLocale">
<option
v-for="locale in locales"
:key="locale.name"
:value="locale.id"
>
{{ locale.name }}-{{ locale.code }}
</option>
</select>
<span v-if="$v.selectedLocale.$error" class="message">
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.LOCALE.ERROR') }}
</span>
</label>
<div class="medium-12 columns">
<div class="modal-footer justify-content-end w-full">
<woot-button class="button clear" @click.prevent="onClose">
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.BUTTONS.CANCEL') }}
</woot-button>
<woot-button>
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.BUTTONS.CREATE') }}
</woot-button>
</div>
</div>
</div>
</form>
</modal>
</template>
<script>
import Modal from 'dashboard/components/Modal';
import alertMixin from 'shared/mixins/alertMixin';
import { required } from 'vuelidate/lib/validators';
import allLocales from 'shared/constants/locales.js';
export default {
components: {
Modal,
},
mixins: [alertMixin],
props: {
show: {
type: Boolean,
default: true,
},
portal: {
type: Object,
default: () => ({}),
},
},
data() {
return {
selectedLocale: '',
isUpdating: false,
};
},
computed: {
addedLocales() {
const { allowed_locales: allowedLocales } = this.portal.config;
return allowedLocales.map(locale => locale.code);
},
locales() {
const addedLocales = this.portal.config.allowed_locales.map(
locale => locale.code
);
return Object.keys(allLocales)
.map(key => {
return {
id: key,
name: allLocales[key],
code: key,
};
})
.filter(locale => {
return !addedLocales.includes(locale.code);
});
},
},
validations: {
selectedLocale: {
required,
},
},
methods: {
async onCreate() {
this.$v.$touch();
if (this.$v.$invalid) {
return;
}
const updatedLocales = this.addedLocales;
updatedLocales.push(this.selectedLocale);
this.isUpdating = true;
try {
await this.$store.dispatch('portals/update', {
portalSlug: this.portal.slug,
config: { allowed_locales: updatedLocales },
});
this.alertMessage = this.$t(
'HELP_CENTER.PORTAL.ADD_LOCALE.API.SUCCESS_MESSAGE'
);
this.onClose();
} catch (error) {
this.alertMessage =
error?.message ||
this.$t('HELP_CENTER.PORTAL.ADD_LOCALE.API.ERROR_MESSAGE');
} finally {
this.showAlert(this.alertMessage);
this.isUpdating = false;
}
},
onClose() {
this.$emit('cancel');
},
},
};
</script>
<style scoped lang="scss">
.input-container::v-deep {
margin: 0 0 var(--space-normal);
input {
margin-bottom: 0;
}
.message {
margin-top: 0;
}
}
</style>

View file

@ -1,185 +0,0 @@
<template>
<modal :show.sync="show" :on-close="onClose">
<woot-modal-header
:header-title="$t('HELP_CENTER.PORTAL.ADD.TITLE')"
:header-content="$t('HELP_CENTER.PORTAL.ADD.SUB_TITLE')"
/>
<form class="row" @submit.prevent="onCreate">
<div class="medium-12 columns">
<woot-input
v-model="name"
:class="{ error: $v.name.$error }"
class="medium-12 columns"
:error="$v.name.$error ? $t('HELP_CENTER.PORTAL.ADD.NAME.ERROR') : ''"
:label="$t('HELP_CENTER.PORTAL.ADD.NAME.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.NAME.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.NAME.HELP_TEXT')"
@blur="$v.name.$touch"
@input="onNameChange"
/>
<woot-input
v-model="slug"
:class="{ error: $v.slug.$error }"
class="medium-12 columns"
:error="$v.slug.$error ? $t('HELP_CENTER.PORTAL.ADD.SLUG.ERROR') : ''"
:label="$t('HELP_CENTER.PORTAL.ADD.SLUG.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.SLUG.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.SLUG.HELP_TEXT')"
@blur="$v.slug.$touch"
/>
<woot-input
v-model="pageTitle"
class="medium-12 columns"
:label="$t('HELP_CENTER.PORTAL.ADD.PAGE_TITLE.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.PAGE_TITLE.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.PAGE_TITLE.HELP_TEXT')"
/>
<woot-input
v-model="headerText"
class="medium-12 columns"
:label="$t('HELP_CENTER.PORTAL.ADD.HEADER_TEXT.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.HEADER_TEXT.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.HEADER_TEXT.HELP_TEXT')"
/>
<woot-input
v-model="domain"
class="medium-12 columns"
:label="$t('HELP_CENTER.PORTAL.ADD.DOMAIN.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.DOMAIN.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.DOMAIN.HELP_TEXT')"
/>
<woot-input
v-model="homePageLink"
class="medium-12 columns"
:label="$t('HELP_CENTER.PORTAL.ADD.HOME_PAGE_LINK.LABEL')"
:placeholder="$t('HELP_CENTER.PORTAL.ADD.HOME_PAGE_LINK.PLACEHOLDER')"
:help-text="$t('HELP_CENTER.PORTAL.ADD.HOME_PAGE_LINK.HELP_TEXT')"
/>
<div class="medium-12 columns">
<div class="modal-footer justify-content-end w-full">
<woot-button
class="button clear"
:is-loading="uiFlags.isCreating"
@click.prevent="onClose"
>
{{ $t('HELP_CENTER.PORTAL.ADD.BUTTONS.CANCEL') }}
</woot-button>
<woot-button>
{{ $t('HELP_CENTER.PORTAL.ADD.BUTTONS.CREATE') }}
</woot-button>
</div>
</div>
</div>
</form>
</modal>
</template>
<script>
import { mapGetters } from 'vuex';
import Modal from 'dashboard/components/Modal';
import alertMixin from 'shared/mixins/alertMixin';
import { required } from 'vuelidate/lib/validators';
import { convertToPortalSlug } from 'dashboard/helper/commons.js';
export default {
components: {
Modal,
},
mixins: [alertMixin],
props: {
show: {
type: Boolean,
default: true,
},
portalName: {
type: String,
default: '',
},
locale: {
type: String,
default: '',
},
},
data() {
return {
name: '',
slug: '',
domain: '',
homePageLink: '',
pageTitle: '',
headerText: '',
alertMessage: '',
};
},
computed: {
...mapGetters({
uiFlags: 'portals/uiFlagsIn',
}),
},
validations: {
name: {
required,
},
slug: {
required,
},
},
methods: {
onNameChange() {
this.slug = convertToPortalSlug(this.name);
},
async onCreate() {
this.$v.$touch();
if (this.$v.$invalid) {
return;
}
try {
await this.$store.dispatch('portals/create', {
portal: {
name: this.name,
slug: this.slug,
custom_domain: this.domain,
// TODO: add support for choosing color
color: '#1f93ff',
homepage_link: this.homePageLink,
page_title: this.pageTitle,
header_text: this.headerText,
config: {
// TODO: add support for choosing locale
allowed_locales: ['en'],
},
},
});
this.alertMessage = this.$t(
'HELP_CENTER.PORTAL.ADD.API.SUCCESS_MESSAGE'
);
this.$emit('cancel');
} catch (error) {
this.alertMessage =
error?.message || this.$t('HELP_CENTER.PORTAL.ADD.API.ERROR_MESSAGE');
} finally {
this.showAlert(this.alertMessage);
}
},
onClose() {
this.$emit('cancel');
},
},
};
</script>
<style scoped lang="scss">
.input-container::v-deep {
margin: 0 0 var(--space-normal);
input {
margin-bottom: 0;
}
.message {
margin-top: 0;
}
}
</style>

View file

@ -28,6 +28,7 @@
</woot-button> </woot-button>
<!-- Hidden since this is in V2 <!-- Hidden since this is in V2
<woot-button <woot-button
v-if="shouldShowAddLocaleButton"
class-names="article--buttons" class-names="article--buttons"
icon="add" icon="add"
color-scheme="secondary" color-scheme="secondary"
@ -88,6 +89,10 @@ export default {
type: Boolean, type: Boolean,
default: false, default: false,
}, },
shouldShowAddLocaleButton: {
type: Boolean,
default: false,
},
}, },
data() { data() {
return { return {

View file

@ -234,7 +234,7 @@ export default {
}, },
methods: { methods: {
addLocale() { addLocale() {
this.$emit('add'); this.$emit('add-locale', this.portal.id);
}, },
openSite() { openSite() {
this.$emit('open-site'); this.$emit('open-site');

View file

@ -6,7 +6,6 @@
:sub-title="subTitle" :sub-title="subTitle"
@open-popover="openPortalPopover" @open-popover="openPortalPopover"
/> />
<sidebar-search @input="onSearch" />
<transition-group name="menu-list" tag="ul" class="menu vertical"> <transition-group name="menu-list" tag="ul" class="menu vertical">
<secondary-nav-item <secondary-nav-item
v-for="menuItem in accessibleMenuItems" v-for="menuItem in accessibleMenuItems"
@ -28,13 +27,11 @@
<script> <script>
import SecondaryNavItem from 'dashboard/components/layout/sidebarComponents/SecondaryNavItem'; import SecondaryNavItem from 'dashboard/components/layout/sidebarComponents/SecondaryNavItem';
import SidebarSearch from './SidebarSearch';
import SidebarHeader from './SidebarHeader'; import SidebarHeader from './SidebarHeader';
export default { export default {
components: { components: {
SecondaryNavItem, SecondaryNavItem,
SidebarSearch,
SidebarHeader, SidebarHeader,
}, },
props: { props: {

View file

@ -15,6 +15,7 @@
:key="portal.id" :key="portal.id"
:portal="portal" :portal="portal"
:status="portalStatus" :status="portalStatus"
@add-locale="addLocale"
/> />
<div v-if="isFetching" class="portals--loader"> <div v-if="isFetching" class="portals--loader">
<spinner /> <spinner />
@ -25,8 +26,15 @@
:title="$t('HELP_CENTER.PORTAL.NO_PORTALS_MESSAGE')" :title="$t('HELP_CENTER.PORTAL.NO_PORTALS_MESSAGE')"
/> />
</div> </div>
<woot-modal :show.sync="isAddModalOpen" :on-close="closeModal"> <woot-modal
<add-portal :show="isAddModalOpen" @cancel="closeModal" /> :show.sync="isAddLocaleModalOpen"
:on-close="closeAddLocaleModal"
>
<add-locale
:show="isAddLocaleModalOpen"
:portal="selectedPortal"
@cancel="closeAddLocaleModal"
/>
</woot-modal> </woot-modal>
</div> </div>
</template> </template>
@ -37,18 +45,19 @@ import alertMixin from 'shared/mixins/alertMixin';
import PortalListItem from '../../components/PortalListItem'; import PortalListItem from '../../components/PortalListItem';
import Spinner from 'shared/components/Spinner.vue'; import Spinner from 'shared/components/Spinner.vue';
import EmptyState from 'dashboard/components/widgets/EmptyState'; import EmptyState from 'dashboard/components/widgets/EmptyState';
import AddPortal from '../../components/AddPortal'; import AddLocale from '../../components/AddLocale';
export default { export default {
components: { components: {
PortalListItem, PortalListItem,
EmptyState, EmptyState,
Spinner, Spinner,
AddPortal, AddLocale,
}, },
mixins: [alertMixin], mixins: [alertMixin],
data() { data() {
return { return {
isAddModalOpen: false, isAddLocaleModalOpen: false,
selectedPortal: {},
}; };
}, },
computed: { computed: {
@ -68,8 +77,13 @@ export default {
addPortal() { addPortal() {
this.$router.push({ name: 'new_portal_information' }); this.$router.push({ name: 'new_portal_information' });
}, },
closeModal() { closeAddLocaleModal() {
this.isAddModalOpen = false; this.isAddLocaleModalOpen = false;
this.selectedPortal = {};
},
addLocale(portalId) {
this.isAddLocaleModalOpen = true;
this.selectedPortal = this.portals.find(portal => portal.id === portalId);
}, },
}, },
}; };

View file

@ -36,8 +36,7 @@ export const actions = {
} }
}, },
update: async ({ commit }, { portalObj }) => { update: async ({ commit }, { portalSlug, ...portalObj }) => {
const portalSlug = portalObj.slug;
commit(types.SET_HELP_PORTAL_UI_FLAG, { commit(types.SET_HELP_PORTAL_UI_FLAG, {
uiFlags: { isUpdating: true }, uiFlags: { isUpdating: true },
portalSlug, portalSlug,

View file

@ -69,7 +69,10 @@ describe('#actions', () => {
describe('#update', () => { describe('#update', () => {
it('sends correct actions if API is success', async () => { it('sends correct actions if API is success', async () => {
axios.patch.mockResolvedValue({ data: apiResponse.payload[1] }); axios.patch.mockResolvedValue({ data: apiResponse.payload[1] });
await actions.update({ commit }, { portalObj: apiResponse.payload[1] }); await actions.update(
{ commit },
{ portalObj: apiResponse.payload[1], portalSlug: 'campaign' }
);
expect(commit.mock.calls).toEqual([ expect(commit.mock.calls).toEqual([
[ [
types.SET_HELP_PORTAL_UI_FLAG, types.SET_HELP_PORTAL_UI_FLAG,
@ -85,7 +88,10 @@ describe('#actions', () => {
it('sends correct actions if API is error', async () => { it('sends correct actions if API is error', async () => {
axios.patch.mockRejectedValue({ message: 'Incorrect header' }); axios.patch.mockRejectedValue({ message: 'Incorrect header' });
await expect( await expect(
actions.update({ commit }, { portalObj: apiResponse.payload[1] }) actions.update(
{ commit },
{ portalObj: apiResponse.payload[1], portalSlug: 'campaign' }
)
).rejects.toThrow(Error); ).rejects.toThrow(Error);
expect(commit.mock.calls).toEqual([ expect(commit.mock.calls).toEqual([
[ [