fix: Add a fix for minor UI / a11y issues (#4905)

This commit is contained in:
Fayaz Ahmed 2022-06-24 23:12:53 +05:30 committed by GitHub
parent dcbca173ac
commit 263b8240d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 35 additions and 12 deletions

View file

@ -4,6 +4,7 @@
.page-sub-title { .page-sub-title {
font-size: $font-size-large; font-size: $font-size-large;
word-wrap: break-word;
} }
.block-title { .block-title {

View file

@ -4,7 +4,7 @@
<h2 class="page-sub-title"> <h2 class="page-sub-title">
{{ headerTitle }} {{ headerTitle }}
</h2> </h2>
<p v-if="headerContent" class="small-12 column"> <p v-if="headerContent" class="small-12 column wrap-content">
{{ headerContent }} {{ headerContent }}
</p> </p>
<slot /> <slot />
@ -29,3 +29,8 @@ export default {
}, },
}; };
</script> </script>
<style scoped lang="scss">
.wrap-content {
word-wrap: break-word;
}
</style>

View file

@ -191,6 +191,7 @@ export default {
display: flex; display: flex;
min-height: 0; min-height: 0;
height: 100%; height: 100%;
width: fit-content;
} }
</style> </style>

View file

@ -83,7 +83,7 @@ export default {
border-bottom-right-radius: var(--border-radius-normal); border-bottom-right-radius: var(--border-radius-normal);
display: flex; display: flex;
height: 100%; height: 100%;
justify-content: end; justify-content: flex-end;
opacity: 1; opacity: 1;
position: absolute; position: absolute;
right: 0; right: 0;

View file

@ -146,6 +146,7 @@ $label-badge-size: var(--space-slab);
height: $label-badge-size; height: $label-badge-size;
min-width: $label-badge-size; min-width: $label-badge-size;
margin-left: var(--space-smaller); margin-left: var(--space-smaller);
border: 1px solid var(--color-border-light);
} }
.badge.secondary { .badge.secondary {

View file

@ -66,7 +66,7 @@
<spinner v-if="isPending" size="tiny" /> <spinner v-if="isPending" size="tiny" />
<div <div
v-if="showAvatar" v-if="showAvatar"
v-tooltip.top="tooltipForSender" v-tooltip.left="tooltipForSender"
class="sender--info" class="sender--info"
> >
<woot-thumbnail <woot-thumbnail
@ -313,7 +313,6 @@ export default {
return showTooltip return showTooltip
? { ? {
content: `${this.$t('CONVERSATION.SENT_BY')} ${name}`, content: `${this.$t('CONVERSATION.SENT_BY')} ${name}`,
classes: 'top',
} }
: false; : false;
}, },

View file

@ -258,6 +258,7 @@ ul {
height: var(--space-slab); height: var(--space-slab);
width: var(--space-slab); width: var(--space-slab);
flex-shrink: 0; flex-shrink: 0;
border: 1px solid var(--color-border-light);
} }
} }
} }

View file

@ -2,10 +2,10 @@
<modal :show.sync="show" :on-close="onClose"> <modal :show.sync="show" :on-close="onClose">
<woot-modal-header :header-title="title" :header-content="message" /> <woot-modal-header :header-title="title" :header-content="message" />
<div class="modal-footer delete-item"> <div class="modal-footer delete-item">
<button class="alert button nice" @click="onConfirm"> <button class="alert button nice text-truncate" @click="onConfirm">
{{ confirmText }} {{ confirmText }}
</button> </button>
<button class="button clear" @click="onClose"> <button class="button clear text-truncate" @click="onClose">
{{ rejectText }} {{ rejectText }}
</button> </button>
</div> </div>

View file

@ -65,6 +65,7 @@
"PLACEHOLDER": "Select date range" "PLACEHOLDER": "Select date range"
}, },
"GROUP_BY_FILTER_DROPDOWN_LABEL": "Group By", "GROUP_BY_FILTER_DROPDOWN_LABEL": "Group By",
"DURATION_FILTER_LABEL": "Duration",
"GROUP_BY_DAY_OPTIONS": [{ "id": 1, "groupBy": "Day" }], "GROUP_BY_DAY_OPTIONS": [{ "id": 1, "groupBy": "Day" }],
"GROUP_BY_WEEK_OPTIONS": [ "GROUP_BY_WEEK_OPTIONS": [
{ "id": 1, "groupBy": "Day" }, { "id": 1, "groupBy": "Day" },

View file

@ -9,6 +9,7 @@
<draggable <draggable
:list="conversationSidebarItems" :list="conversationSidebarItems"
:disabled="!dragEnabled" :disabled="!dragEnabled"
animation="200"
class="list-group" class="list-group"
ghost-class="ghost" ghost-class="ghost"
handle=".drag-handle" handle=".drag-handle"

View file

@ -31,7 +31,9 @@
</thead> </thead>
<tbody> <tbody>
<tr v-for="(label, index) in records" :key="label.title"> <tr v-for="(label, index) in records" :key="label.title">
<td>{{ label.title }}</td> <td class="label-title">
<span class="text-truncate">{{ label.title }}</span>
</td>
<td>{{ label.description }}</td> <td>{{ label.description }}</td>
<td> <td>
<div class="label-color--container"> <div class="label-color--container">
@ -201,5 +203,12 @@ export default {
height: $space-normal; height: $space-normal;
margin-right: $space-smaller; margin-right: $space-smaller;
width: $space-normal; width: $space-normal;
border: 1px solid var(--color-border-light);
}
.label-title {
span {
width: var(--space-giga);
display: inline-block;
}
} }
</style> </style>

View file

@ -1,7 +1,7 @@
<template> <template>
<div class="flex-container flex-dir-column medium-flex-dir-row"> <div class="flex-container flex-dir-column medium-flex-dir-row">
<div v-if="type === 'agent'" class="small-12 medium-3 pull-right"> <div v-if="type === 'agent'" class="small-12 medium-3 pull-right">
<p aria-hidden="true" class="hide"> <p>
{{ $t('AGENT_REPORTS.FILTER_DROPDOWN_LABEL') }} {{ $t('AGENT_REPORTS.FILTER_DROPDOWN_LABEL') }}
</p> </p>
<multiselect <multiselect
@ -43,7 +43,7 @@
</multiselect> </multiselect>
</div> </div>
<div v-else-if="type === 'label'" class="small-12 medium-3 pull-right"> <div v-else-if="type === 'label'" class="small-12 medium-3 pull-right">
<p aria-hidden="true" class="hide"> <p>
{{ $t('LABEL_REPORTS.FILTER_DROPDOWN_LABEL') }} {{ $t('LABEL_REPORTS.FILTER_DROPDOWN_LABEL') }}
</p> </p>
<multiselect <multiselect
@ -89,7 +89,7 @@
</multiselect> </multiselect>
</div> </div>
<div v-else class="small-12 medium-3 pull-right"> <div v-else class="small-12 medium-3 pull-right">
<p aria-hidden="true" class="hide"> <p>
{{ $t('INBOX_REPORTS.FILTER_DROPDOWN_LABEL') }} {{ $t('INBOX_REPORTS.FILTER_DROPDOWN_LABEL') }}
</p> </p>
<multiselect <multiselect
@ -107,6 +107,9 @@
/> />
</div> </div>
<div class="small-12 medium-3 pull-right margin-left-small"> <div class="small-12 medium-3 pull-right margin-left-small">
<p>
{{ $t('REPORT.DURATION_FILTER_LABEL') }}
</p>
<multiselect <multiselect
v-model="currentDateRangeSelection" v-model="currentDateRangeSelection"
track-by="name" track-by="name"
@ -133,7 +136,7 @@
v-if="notLast7Days" v-if="notLast7Days"
class="small-12 medium-3 pull-right margin-left-small" class="small-12 medium-3 pull-right margin-left-small"
> >
<p aria-hidden="true" class="hide"> <p>
{{ $t('REPORT.GROUP_BY_FILTER_DROPDOWN_LABEL') }} {{ $t('REPORT.GROUP_BY_FILTER_DROPDOWN_LABEL') }}
</p> </p>
<multiselect <multiselect

View file

@ -94,6 +94,7 @@ export default {
margin-top: var(--space-micro); margin-top: var(--space-micro);
min-width: var(--space-slab); min-width: var(--space-slab);
width: var(--space-slab); width: var(--space-slab);
border: 1px solid var(--color-border-light);
} }
} }
</style> </style>