KumiSystems/Chatwoot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat: Add missing password validation at signup (#4441)

Browse source 
Co-authored-by: Pranav Raj S <pranav@chatwoot.com>
This commit is contained in:
Sivin Varghese 2022-04-12 11:08:12 +05:30 • committed by GitHub
parent c64e2e3bc5
commit 14503b5fe0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 49 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/javascript/shared/helpers/Validators.js
View file

@ -2,3 +2,17 @@ export const isPhoneE164 = value => !!value.match(/^\+[1-9]\d{1,14}$/);
export const isPhoneE164OrEmpty = value => isPhoneE164(value) || value === '';
export const shouldBeUrl = (value = '') =>
value ? value.startsWith('http') : true;
export const isValidPassword = value => {
const containsUppercase = /[A-Z]/.test(value);
const containsLowercase = /[a-z]/.test(value);
const containsNumber = /[0-9]/.test(value);
const containsSpecialCharacter = /[!@#$%^&*()_+\-=[\]{}|'"/\\.,`<>:;?~]/.test(
value
);
return (
containsUppercase &&
containsLowercase &&
containsNumber &&
containsSpecialCharacter
);
};

17
app/javascript/shared/helpers/specs/ValidatorsHelper.spec.js
View file

@ -1,7 +1,24 @@
import { shouldBeUrl } from '../Validators';
import { isValidPassword } from '../Validators';
describe('#shouldBeUrl', () => {
it('should return correct url', () => {
expect(shouldBeUrl('http')).toEqual(true);
});
});
describe('#isValidPassword', () => {
it('should return correct password', () => {
expect(isValidPassword('testPass4!')).toEqual(true);
expect(isValidPassword('testPass4-')).toEqual(true);
expect(isValidPassword('testPass4\\')).toEqual(true);
expect(isValidPassword("testPass4'")).toEqual(true);
});
it('should return wrong password', () => {
expect(isValidPassword('testpass4')).toEqual(false);
expect(isValidPassword('testPass4')).toEqual(false);
expect(isValidPassword('testpass4!')).toEqual(false);
expect(isValidPassword('testPass!')).toEqual(false);
});
});